[Bug 14296] New: Introduce upload settings, check size and translate alerts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Bug ID: 14296 Summary: Introduce upload settings, check size and translate alerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14294 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff Depends on| |14295 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39669&action=edit Bug 14296: Introduce upload settings [database revision] This patch adds the table upload_settings. An interface for this table will be created on a subsequent report. The table will be used first to implement a check on upload size and quota. The table allows to add settings on a general level (no borrower) and on a (staff) user level overriding general settings. Test plan: Run new install or upgrade in the webinstaller. You can also run the sql files from the command line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39670&action=edit Bug 14296: Introduce upload settings, check size and translate alerts This patch includes: [1] Add sub MaxUploadSize to module and add unit test. Note that normally the table will still be empty, but a large fallback is used. [2] Check the max upload size for the user when submitting the form and again when processing it. [3] Make it possible to translate some alerts in upload.tt. Also it moves the input[type=file] control to the template. Test plan: [1] Upload a file. No restrictions. [2] Run UploadedFiles.t. [3] Add a record (sorry, interface is another report) via mysql into upload_settings: type=filesize, count1=1000. [4] Upload a file larger than 1000 bytes. Should not be possible. [5] Upload a smaller file. [6] Bonus: I tested the second size check by adding a return true in the javascript validation after the first size check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Introduce upload settings, |Introduce upload settings, |check size and translate |add quota and translate |alerts |alerts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39766&action=edit Bug 14296: Add checks for upload quota This patch includes: [1] A new routine CheckQuota in module UploadedFiles. [2] Unit tests for CheckQuota in Uploadedfiles.t [3] A check of the quota before uploading a file in upload.pl and a warning in the template if you exceeded these quota already. Test plan: [1] Delete all records from upload_settings (if any). [2] Upload a file. No restrictions. [3] Add a record in upload_settings with type=spacequota, count1=5000 and count2=1. (Yes, an interface will be added.) [4] Upload a file smaller than 5000 bytes. No restriction. [5] Upload another file making sure that the size of both files exceeds 5000 bytes. Your upload should be stopped. [6] Run the unit test with additional item and space quota tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- One moment.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39766|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39768&action=edit Bug 14296: Add checks for upload quota This patch includes: [1] A new routine CheckQuota in module UploadedFiles. [2] Unit tests for CheckQuota in Uploadedfiles.t [3] A check of the quota before uploading a file in upload.pl and a warning in the template if you exceeded these quota already. Test plan: [1] Delete all records from upload_settings (if any). [2] Upload a file. No restrictions. [3] Add a record in upload_settings with type=spacequota, count1=5000 and count2=1. (Yes, an interface will be added.) [4] Upload a file smaller than 5000 bytes. No restriction. [5] Upload another file making sure that the size of both files exceeds 5000 bytes. Your upload should be stopped. [6] Run the unit test with additional item and space quota tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14295 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 [Bug 14295] Add creation time, size and owner for uploaded files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Marked as blocked, but does not say what it depends on. Is the status correct? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, no dependency either - Marcel set the status himself. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Mirko Tietgen from comment #6)
Marked as blocked, but does not say what it depends on. Is the status correct?
Yes, I changed it. I will come back to this dev, as soon as time permits :) It certainly will need rebasing since I gave priority to bug 14321.. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org