[Bug 37745] New: "Rows per page" not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Bug ID: 37745 Summary: "Rows per page" not working Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170760&action=edit Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks for verifying this and raising a bug, Jonathan. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 37746 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170760|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170772&action=edit Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170772|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170776&action=edit Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Rows per page" not working |Duplicate class attributes | |break dropdown items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170858&action=edit Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Can we get a quick SO+QA on this second patch please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170859&action=edit Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- No test plan for this last patch as it touches a lot of code. But more eyes are needed here, and fast: it seems that this last patch is fixing a lot of bugs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170776|0 |1 is obsolete| | Attachment #170858|0 |1 is obsolete| | Attachment #170859|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170866&action=edit Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170867&action=edit Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170868&action=edit Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170869&action=edit Bug 37745: (follow-up) Remove "btn-default" from two controls. If we use "btn-link" we don't need "btn-default". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Please push this, it will fix a lot of bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items Applying: Bug 37745: Fix change framework Applying: Bug 37745: Remove more duplicated class attributes error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170866|0 |1 is obsolete| | Attachment #170867|0 |1 is obsolete| | Attachment #170868|0 |1 is obsolete| | Attachment #170869|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170943&action=edit Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170944&action=edit Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170945&action=edit Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170946&action=edit Bug 37745: (follow-up) Remove "btn-default" from two controls. If we use "btn-link" we don't need "btn-default". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #21 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 37778 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 Bug 37745 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org