[Bug 20709] New: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bug ID: 20709 Summary: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75044&action=edit Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Translation of bibliographic and authority frameworks can be done using translate.koha-community.org. Updated and translated files will then be provided for download. See: http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.h... To test: - Verify SQL is correct and frameworks load without problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 75044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75044 Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Review of attachment 75044: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20709&attachment=75044) ----------------------------------------------------------------- ::: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql @@ +86,4 @@
UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 'r' AND frameworkcode = 'FA'; UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 's' AND frameworkcode = 'FA'; UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 'x' AND frameworkcode = 'FA'; +
If a blank line is the only difference, perhaps it should not be part of the patch? ::: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql @@ -520,5 @@
-INSERT INTO marc_subfield_structure(tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, frameworkcode, seealso, link, defaultvalue, maxlength) -SELECT tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, 'ACQ', seealso, link, defaultvalue, maxlength -FROM marc_subfield_structure -WHERE frameworkcode="" -AND kohafield IN ("biblio.title", "biblio.author", "biblioitems.publishercode", "biblioitems.editionstatement", "biblio.copyrightdate", "biblioitems.isbn", "biblio.seriestitle" );
Why remove this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Also, why no atomic update to correct current systems doing an upgrade? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Because we don't do atomic updates in this case, we don't want to mess with what people have set up for their use. Note: these files have been auto-generated so I am just copying them into the right spot. If that changes a blank line, I am still ok with it :) If you take a closer look you can see that the ACQ framework has been moved into another file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Katrin, Bug 27010 adds a few new subfields. Translated files have been updated accordingly. Maybe you could consider updating the patch (23+24+25+26) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75248&action=edit Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018) A follow-up in line with bug 20710. Again, the files used here have been generated automatically from the po files on translate.koha-community.org. To test: - Make sure the de-DE installer can install all mandatory files cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Bernardo Gonzalez Kriegel from comment #5)
Hi Katrin, Bug 27010 adds a few new subfields. Translated files have been updated accordingly.
Maybe you could consider updating the patch (23+24+25+26)
Done, thx Bernardo! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update GERMAN MARC |Update GERMAN MARC |frameworks to Updates |frameworks to Updates 23-26 |23+24+25 (Nov 2016, May and |(Nov 2016, May and Apr |Dec 2017) |2018) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75044|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 75386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75386&action=edit Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Translation of bibliographic and authority frameworks can be done using translate.koha-community.org. Updated and translated files will then be provided for download. See: http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.h... To test: - Verify SQL is correct and frameworks load without problem Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75248|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 75387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75387&action=edit Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018) A follow-up in line with bug 20710. Again, the files used here have been generated automatically from the po files on translate.koha-community.org. To test: - Make sure the de-DE installer can install all mandatory files cleanly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using de-DE installer, all files load Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I did a little change on marc21 bib framework file, line 4596 from INSERT IGNORE INTO biblio_framework VALUES( 'ACQ', 'Acquisition framework' ); to INSERT IGNORE INTO biblio_framework VALUES ( 'ACQ', 'Erwerbung' ); Original EN file need a little update to allow translation. The one used to translate is fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- About the changes to installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql, should not we added them on bug 19835? We are going to have these files differ, again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #12)
About the changes to installer/data/mysql/de-DE/marcflavour/marc21/mandatory/ authorities_normal_marc21.sql, should not we added them on bug 19835?
We are going to have these files differ, again.
Hi Jonathan On master+19835+20710 en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385 lines On master+20709 de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385 lines too They will differ in that one is the translation of the other, but they are basically the same file. The only thing is that translations are made using master+19835+20710, so they will differ (a little) until 19835 & 20710 are pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about other languages? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think some have translated manually, so might not be so easy to switch them to the generated files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #14)
What about other languages?
Not all languages that have translated sql files (marc21 project on translation server) have custom install dirs, so is up to each language maintainer what to do with those sql files. It would be better if we could 'translate' sql files using the normal way, but it's no easy task. I tried a while ago using XML files... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure you got my point. This patch adds '034', '1', 'Real World Object URI After bug 19835 and bug 20709: % git grep -l "'034', '1'" installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql installer/data/mysql/de-DE/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql We usually apply the changes done on 'en' to all other languages (not translated), then language maintainers provide patches for the translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #17)
I am not sure you got my point.
This patch adds '034', '1', 'Real World Object URI
After bug 19835 and bug 20709: % git grep -l "'034', '1'" installer/data/mysql/de-DE/marcflavour/marc21/mandatory/ authorities_normal_marc21.sql installer/data/mysql/de-DE/marcflavour/marc21/mandatory/ marc21_framework_DEFAULT.sql installer/data/mysql/en/marcflavour/marc21/mandatory/ authorities_normal_marc21.sql installer/data/mysql/en/marcflavour/marc21/mandatory/ marc21_framework_DEFAULT.sql
We usually apply the changes done on 'en' to all other languages (not translated), then language maintainers provide patches for the translation.
That's not how we do it anymore for the frameworks. Bernardo provides po files for translating, which is much more convenient and less error prone then translating a gigantig sql file. So we generate the translated files from the files in master. See here: http://translate.koha-community.org/projects/marc21/ Bernardo automatically generates the files regularly and provides them here: http://translate.koha-community.org/files/ For the frameworks it's not super bad if a field is missing, I think the new workflow is worth it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fields will be missing and files will differ if language maintainers do not provide files for their language. That sounds weird. It does not seems difficult to provide the changes for all languages on bug 19835. Where was the announce about this change? Where is describe the workflow? On the koha translate list? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- See first comment: http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.h... But it's been done for a while, Bernardo might know when we started. I've update the files a few times already. I think they are already out of sync. Some files might also have different data because they were translted manually and renamed/restructured/changed. Bugzilla search: ALL german update frameworks bug 16601 bug 16472 bug 10964 Italian and I think ru-RU have also been updated a while ago. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #17)
I am not sure you got my point.
May be not :)
This patch adds '034', '1', 'Real World Object URI ... We usually apply the changes done on 'en' to all other languages (not translated), then language maintainers provide patches for the translation.
Not for frameworks, or more exactly not be me. I only check for updates/changes on EN 'default' framework, bib and auth. Bug 10963 and Bug 10488 guarantees that you only need to add/update things once per file, before them changes were needed on many places in the same file which I did not do either. But I never tried to update frameworks for other languages. (In reply to Jonathan Druart from comment #19)
Fields will be missing and files will differ if language maintainers do not provide files for their language. That sounds weird. It does not seems difficult to provide the changes for all languages on bug 19835.
Yes, there will be differences. But it's not easy for me to do that job. That was the reason to introduce 'marc21' project on translation server as a way to enable the translation of 5 sql files. The po file for that is built in a very non standard way, and the translations generated by an ugly script. But it's doing it's job since mid 2013.
Where was the announce about this change? Where is describe the workflow? On the koha translate list?
It was made in the translation list, 5 years ago. Languages have been added upon request. There are even languages that do not have SQL installers. But you are quite right, there is a lack of documentation on the workflow. Finally, I promise never to update the sql translations again until the corresponding changes are in master :) PS: I need to resurrect Bug 13897 or find a way to teach SQL to translate script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75386|0 |1 is obsolete| | Attachment #75387|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75884&action=edit Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Translation of bibliographic and authority frameworks can be done using translate.koha-community.org. Updated and translated files will then be provided for download. See: http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.h... To test: - Verify SQL is correct and frameworks load without problem Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75885&action=edit Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018) A follow-up in line with bug 20710. Again, the files used here have been generated automatically from the po files on translate.koha-community.org. To test: - Make sure the de-DE installer can install all mandatory files cleanly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using de-DE installer, all files load Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an enhancement, many librarians would see it as a bug not being in sync with MARC21 guidelines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bug 20709 depends on bug 19835, which changed state. Bug 19835 Summary: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #25)
Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an enhancement, many librarians would see it as a bug not being in sync with MARC21 guidelines.
Same for 17.11.x, will be in 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update GERMAN MARC |Update German MARC |frameworks to Updates 23-26 |frameworks to Updates 23-26 |(Nov 2016, May and Apr |(Nov 2016, May and Apr |2018) |2018) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org