[Bug 26693] New: Add option to update dateaccessioned when receiving an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Bug ID: 26693 Summary: Add option to update dateaccessioned when receiving an order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl For libraries that create item records when placing an order, the dateaccessioned field gets set with the date on which the record was created, which may be several months prior to when the item actually arrives at the library. Once the item arrives and enters circulation, it may be more useful for collection management purposes to record a dateaccessioned linked to when the item actually arrived at the library. I'd like to see a new Acquisitions syspref to give the option to re-set the dateaccessioned when marking an item received. This would only apply to items that were created at time or ordering and are therefore linked to an order. In these cases, the acq data is already remembering when the order was placed so we're really not losing anything by changing dateaccessioned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- What about a checkbox about this when adding the items to the orderlines? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #2)
What about a checkbox about this when adding the items to the orderlines?
When you say "adding items to orderlines" do you mean when adding an order to a basket and creating items then? Or do you mean when creating items on receiving? We've got at least those two possible workflows that need to be accommodated. And it really needs to have some global default selection. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #3)
(In reply to Tomás Cohen Arazi from comment #2)
What about a checkbox about this when adding the items to the orderlines?
When you say "adding items to orderlines" do you mean when adding an order to a basket and creating items then? Or do you mean when creating items on receiving? We've got at least those two possible workflows that need to be accommodated. And it really needs to have some global default selection.
I mean in the context items are created, I was thinking when adding items to a basket, but really meant any step in the workflow there items are created. So the user marks the order marked to update the items on receiving. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's probably only needed when items are created on order, then we would want to update on receive. So maybe the checkbox should be on the receive page when linked items exist? Also totally agree with Andrew about the global default setting! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- So a global setting, and the option to change that global default on receiving? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #6)
So a global setting, and the option to change that global default on receiving?
I think so. Andrew, do you agree or did we miss something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
(In reply to Tomás Cohen Arazi from comment #6)
So a global setting, and the option to change that global default on receiving?
I think so. Andrew, do you agree or did we miss something?
Sounds good to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27671 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671 [Bug 27671] Missing include in orderreceive.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I implemented this all: - Syspref - Checkboxes per item, set by default using the syspref - Tweaked finishreceive.pl so it reads the checkboxes and updates dateaccessioned when required. Coool. BUT disabling the date didn't work. So I tried without any patches: MariaDB [koha_kohadev]> SELECT items.itemnumber, dateaccessioned FROM items WHERE itemnumber IN (SELECT itemnumber FROM aqorders_items WHERE ordernumber IN (SELECT ordernumber FROM aqorders WHERE basketno=1)); +------------+-----------------+ | itemnumber | dateaccessioned | +------------+-----------------+ | 973 | 2021-02-11 | | 974 | 2021-02-11 | +------------+-----------------+ 2 rows in set (0.00 sec) MariaDB [koha_kohadev]> UPDATE items SET dateaccessioned='2021-02-09' WHERE itemnumber IN (SELECT itemnumber FROM aqorders_items WHERE ordernumber IN (SELECT ordernumber FROM aqorders WHERE basketno=1)); Query OK, 10 rows affected (0.01 sec) Rows matched: 10 Changed: 10 Warnings: 0 MariaDB [koha_kohadev]> SELECT items.itemnumber, dateaccessioned FROM items WHERE itemnumber IN (SELECT itemnumber FROM aqorders_items WHERE ordernumber IN (SELECT ordernumber FROM aqorders WHERE basketno=1)); +------------+-----------------+ | itemnumber | dateaccessioned | +------------+-----------------+ | 973 | 2021-02-09 | | 974 | 2021-02-09 | +------------+-----------------+ 2 rows in set (0.00 sec) MariaDB [koha_kohadev]> SELECT items.itemnumber, dateaccessioned FROM items WHERE itemnumber IN (SELECT itemnumber FROM aqorders_items WHERE ordernumber IN (SELECT ordernumber FROM aqorders WHERE basketno=1)); +------------+-----------------+ | itemnumber | dateaccessioned | +------------+-----------------+ | 973 | 2021-02-11 | | 974 | 2021-02-11 | +------------+-----------------+ 2 rows in set (0.00 sec) BUMMER. So the actual behavior is that dateaccessioned gets updated regardless. I will upload my patches here anyway, just in case this behavior I found is incorrect and gets fixed on another bug report, and then we come back to this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 116717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116717&action=edit Bug 26693: Add AcqItemSetDateAccessionedsWhenReceived syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 116718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116718&action=edit Bug 26693: Add option to update dateaccessioned when receiving an order This patchset adds: - A new syspref: AcqItemSetDateAccessionedsWhenReceived - A new column on the receive page when items are created on ordering, with a checkbox for choosing if they want the date updated - The checkbox default value honours the global syspref. To test: Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Bug 26693 depends on bug 27671, which changed state. Bug 27671 Summary: Missing include in orderreceive.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org