[Bug 16793] New: Use Font Awesome for arrows instead of images in audio_alerts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Bug ID: 16793 Summary: Use Font Awesome for arrows instead of images in audio_alerts.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org This changes fit with bug 16148 for marc modification template management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52673&action=edit Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52675|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52823&action=edit Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=16794 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |16148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 [Bug 16148] Revised layout and behavior of marc modification template management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Frédéric, some style definitions may be missing in 16.05 (.overline, .underline, .order-control) since they are introduced by bug 16148, which is not in 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Julian Maurice from comment #6)
Frédéric, some style definitions may be missing in 16.05 (.overline, .underline, .order-control) since they are introduced by bug 16148, which is not in 16.05.x
Thanks a lot for catching this! You're totally correct. Those CSS rules are missing in 16.05.x. The visual effect is almost unnoticeable, but it's there. I will fix that. Thks again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 54513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54513&action=edit Bug 16793 [16.05] Add 3 missing css rules -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org