[Bug 16423] New: Fix t/db_dependent/www/batch.t so it matches new layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Bug ID: 16423 Summary: Fix t/db_dependent/www/batch.t so it matches new layout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com To reproduce: - Run $ prove t/db_dependent/www/batch.t => FAIL: Several tests fail due to page layout/information problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51116&action=edit Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout This patch adjusts batch.t so it matches the use of datatables on the 'Manage staged records' page, and small layout changes already fixed on search_utf8.t. The tests are slightly modified so they actually test interesting stuff. Some were passing only because an undefined value was passed. To test: - On master, run $ prove t/db_dependent/www/batch.t => FAIL: Tests fail notably - Apply the patch - Run: $ prove t/db_dependent/www/batch.t => SUCCESS: Notice tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51117&action=edit Bug 16423: (followup) Add more tests On fixing this tests, we retrieved the JSON data for the datatable used on the 'Manage staged records' page. It would be cool to check the data it carries makes sense. To test: - Run t/db_dependent/www/batch.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Before patch I found not ok 7 - upload succeeded and this message malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "<!DOCTYPE html>\n<!-...") at t/db_dependent/www/batch.t line 104. After patch, test 7 pass and no message, but test 23 fails not ok 23 - bib is gone # Failed test 'bib is gone' # at t/db_dependent/www/batch.t line 201. # searched: "\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}<!DOCTYPE html>\x{0a}<!-- TEMPLATE FILE: detail"... # can't find: "The record you requested does not exist" # LCSS: " record y" # LCSS context: "ave been uploaded for this bibliographic record ye" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Is that on current master?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4)
Is that on current master??
Yes. a7446eb Bug 16423: (followup) Add more tests c802f5b Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout 4d0d52e Revert "Bug 16104: Remove warnings "used only once: possible typo"" b20ba02 Bug 15533 - DBRev - Update OldReserve schema file to match database schema 68dbe84 Bug 14632: Add Copyright for the Koha Dev Team .... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passes with me (one warning): 1..24 Use of uninitialized value $opac in substitution (s///) at t/db_dependent/www/batch.t line 55. ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page ok 4 - open tools module ok 5 - go to stage MARC ok 6 - uploaded file ok 7 - upload succeeded ok 8 - reopen stage MARC page ok 9 - stage MARC ok 10 - have job ID ok 11 - job was completed ok 12 - reopen stage MARC page at end of upload ok 13 - stage MARC ok 14 - view batch ok 15 - get the datatable for the new batch id ok 16 - found book ok 17 - record marked as staged ok 18 - record has no matches ok 19 - imported records into catalog ok 20 - record marked as imported ok 21 - revert import ok 22 - getting reverted bib ok 23 - bib is gone ok 24 - record marked as reverted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51116|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51149&action=edit [SIGNED-OFF] Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout This patch adjusts batch.t so it matches the use of datatables on the 'Manage staged records' page, and small layout changes already fixed on search_utf8.t. The tests are slightly modified so they actually test interesting stuff. Some were passing only because an undefined value was passed. To test: - On master, run $ prove t/db_dependent/www/batch.t => FAIL: Tests fail notably - Apply the patch - Run: $ prove t/db_dependent/www/batch.t => SUCCESS: Notice tests now pass. - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51117|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51150&action=edit [SIGNED-OFF] Bug 16423: (followup) Add more tests On fixing this tests, we retrieved the JSON data for the datatable used on the 'Manage staged records' page. It would be cool to check the data it carries makes sense. To test: - Run t/db_dependent/www/batch.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All test pass prove t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51149|0 |1 is obsolete| | Attachment #51150|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51151&action=edit Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout This patch adjusts batch.t so it matches the use of datatables on the 'Manage staged records' page, and small layout changes already fixed on search_utf8.t. The tests are slightly modified so they actually test interesting stuff. Some were passing only because an undefined value was passed. To test: - On master, run $ prove t/db_dependent/www/batch.t => FAIL: Tests fail notably - Apply the patch - Run: $ prove t/db_dependent/www/batch.t => SUCCESS: Notice tests now pass. - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51152&action=edit Bug 16423: (followup) Add more tests On fixing this tests, we retrieved the JSON data for the datatable used on the 'Manage staged records' page. It would be cool to check the data it carries makes sense. To test: - Run t/db_dependent/www/batch.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All test pass prove t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. ok All tests successful. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51155&action=edit Bug 16423: [QA Follow-up] Remove $opac It is not used. And even may raise an uninitialized warnings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Test still passes :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Marcel, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16423 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 [Bug 18807] www/batch.t is failing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org