[Bug 24365] New: Using strict from TmplTokenizer.pm broke the translator script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Bug ID: 24365 Summary: Using strict from TmplTokenizer.pm broke the translator script Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation: kohadev-koha@5dbfd5c26b19:/kohadevbox/koha$ prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. 1/? # Failed test 'opac_bootstrap templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/nUR3OD9D9y:19466:8: invalid multibyte sequence # # msgmerge: found 1 fatal error # xt/author/translatable-templates.t .. 2/? # Failed test 'staff_prog templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/DdbDRQTBzl:6111:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:6122:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:10911:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:11301:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:49459:66: invalid multibyte sequence # # /tmp/DdbDRQTBzl:65223:27: invalid multibyte sequence # # /tmp/DdbDRQTBzl:88587:10: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:43: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:71: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94549:8: invalid multibyte sequence # # msgmerge: found 10 fatal errors # # Looks like you failed 2 tests of 2. xt/author/translatable-templates.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- xt/author/translatable-templates.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=1, Tests=2, 8 wallclock secs ( 0.02 usr 0.01 sys + 8.55 cusr 0.08 csys = 8.66 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96896&action=edit Bug 24365: (bug 24217 follow-up) Fix encoding issue for translator script I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation. It has been caught by a failing test: % prove xt/author/translatable-templates.t will display lines "invalid multibyte sequence" I did a diff between the generated files and found: < msgid "Ã rbok" ---
msgid "Årbok"
Which made me think of an encoding issue. Specifying the encoding when write open the file fixes the problem. Test plan: % prove xt/author/translatable-templates.t must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix, PQA and Pushing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Bug 24365 depends on bug 24217, which changed state. Bug 24217 Summary: use strict for all modules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #4 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305 [Bug 25305] Double UTF-8 encoding on translation files -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org