[Bug 37182] New: 'datetime' field lost on pseudonymization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Bug ID: 37182 Summary: 'datetime' field lost on pseudonymization Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |34611 CC| |andrewfh@dubcolib.org, | |nick@bywatersolutions.com, | |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 [Bug 34611] Add a script for pseudonymizing existing data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 168094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168094&action=edit Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 168095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168095&action=edit Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168094|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168114&action=edit Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168095|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168115&action=edit Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Straightforward and covered by tests, straight to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34611 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a regression release notes| |where the datetime field | |was lost when using the | |pseudonymization command | |line script added in Koha | |24.05 (see bug 34611). It | |also adds new tests. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes a regression |This fixes a regression release notes|where the datetime field |where the datetime field |was lost when using the |was lost when using the |pseudonymization command |pseudonymization command |line script added in Koha |line script added in Koha |24.05 (see bug 34611). It |24.05 |also adds new tests. |(misc/maintenance/pseudonym | |ize_statistics.pl, see bug | |34611). It also adds new | |tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- No change to the manual required - fixing a regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37182 Bug 37182 depends on bug 34611, which changed state. Bug 34611 Summary: Add a script for pseudonymizing existing data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org