[Bug 38979] New: Standardize word spacing for Cardnumber and Borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Bug ID: 38979 Summary: Standardize word spacing for Cardnumber and Borrowernumber Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org A discerning librarian of mine pointed out that the moremember.pl page shows "Card number" and "Borrowernumber". They asked for a space to be added to make the latter "Borrower number", which honestly makes a lot of sense. While I think that's a good starting point, I figured I'd raise this issue to cover all the different instances for both. $ grep -R "Card number" koha-tmpl/* | wc -l 36 $ grep -R "Cardnumber" koha-tmpl/* | wc -l 7 $ grep -R "Borrowernumber" koha-tmpl/* | wc -l 11 $ grep -R "Borrower number" koha-tmpl/* | wc -l 1 Chances are that there are more instances with lower cased initial letters, but cardnumber and borrowernumber are valid in links... It would probably be wise to add a coding guideline for this as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Although it's not on our Terminology page (https://wiki.koha-community.org/wiki/Terminology), we've had discussions about it before. "cardnumber" as one word is incorrect unless it's referring specifically to a database column. "borrowernumber" always refers to a database column, and thus has been kept as one word where it is shown to the user. Separating it into "Borrower number" would be confusing because we don't use the word "borrower" in the default American English templates to refer to patrons. Some of the instances of "borrowernumber" in the staff interface templates are part of operations where the user knows that borrowernumber is a database column because they're doing an import of some kind (tools/modborrowers.t, patron_lists/list.tt). Originally the patron detail pages did not show the borrowernumber on the assumption that it wasn't relevant, but it was later requested that it be added to the display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #1)
Although it's not on our Terminology page (https://wiki.koha-community.org/wiki/Terminology), we've had discussions about it before.
In that case, it sounds like "Borrower number" in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt should become "Borrowernumber"? And "Cardnumbers" in koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt should become "Card numbers"? I suppose this one is debateable. I reckon it might be worth putting into the Terminology in any case. (In reply to Owen Leonard from comment #1)
Originally the patron detail pages did not show the borrowernumber on the assumption that it wasn't relevant, but it was later requested that it be added to the display.
That does sound familiar now that you mention it. One day I'd love to transition from borrowernumber to UUID for security purposes and then it'll get even more interesting... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177708&action=edit Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177708|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177944&action=edit Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177944|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177945&action=edit Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177945|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 178117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178117&action=edit Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This changes "cardnumber" release notes| |to "card number" on the | |Tools > Patron lists pages. --- Comment #7 from David Nind <david@davidnind.com> --- I've added to the Terminology page in the wiki as proposed term changes https://wiki.koha-community.org/wiki/Terminology I've added to the next documentation meeting for approval. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 --- Comment #8 from David Nind <david@davidnind.com> --- I notice that for the table (and other tables0, and not related to this bug, that the column label is "Card". This seems wrong to me, and I think it should be "Card number". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178117|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178447&action=edit Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Standardize word spacing |Standardize word spacing |for Cardnumber and |for Cardnumber |Borrowernumber | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This has already been added to the terminology page, and I created a bug to correct the instances in the manual (Bug 39455). Whenever it has gone through all the release maintainers, there is no need to set it to Needs Documenting. You can close it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38979 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |RESOLVED --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport 24.11.x to avoid creating translation work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org