[Bug 6459] New: Needless call to C4::Context->dbh in C4::Templates::themelanguage()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Bug #: 6459 Summary: Needless call to C4::Context->dbh in C4::Templates::themelanguage() Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: magnus@enger.priv.no QAContact: koha-bugs@lists.koha-community.org As far as I can see, line 194 in C4::Templates::themelanguage() is not needed: my $dbh = C4::Context->dbh; $dbh does not seem to be used again in the scope in which it is created. Patch coming up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> 2011-06-04 17:53:59 UTC --- Created attachment 4358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4358 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4358|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-06 20:26:13 UTC --- Created attachment 4385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4385 Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage() As far as I can tell, $dbh is never used again in the scope in which it is created. This patch simply removes the line. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-06 20:26:40 UTC --- Yep, it is a needless call, signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-09 23:21:48 UTC --- And pushed to master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6459 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org