[Bug 37219] New: In OPAC, "Copy number" column for selecting item-level hold is confusingly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Bug ID: 37219 Summary: In OPAC, "Copy number" column for selecting item-level hold is confusingly named Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When placing an item-level hold in the OPAC, the column to select your item(s) using a radio button or checkbox is called "Copy number". This doesn't accurately describe what it is. The same column when placing a hold from the staff intranet is called "Hold", which makes more sense since you're selecting the item(s) you want to hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- It's still a bit confusing, but less confusing, if you use copy numbers, since then the column looks like: ( ) 1 ( ) 1 ( ) 2 ( ) 2 ( ) 4 which is probably nice if you are doing a item-level hold because of copy number. I never have done that in the OPAC, only for a particular enumchron or a particular home or holding branch, but maybe some people do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|24.05 |Main --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I propose this change: - Split the radio button and copy number into two different columns - Add column configuration to the table so that libraries that don't use copy numbers can hide the column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In OPAC, "Copy number" |In OPAC item holds, |column for selecting |separate copy number from |item-level hold is |radio button and add table |confusingly named |configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37229 [Bug 37229] Table configuration listings for course reserves incorrect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168465&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168465|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168564&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168564|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171455&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171455|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174551&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @Joubu can you please check if that is OK to push with the recent DT work and the work to come? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Pretty sure this does not work correctly. If you have table's headers depending on syspref, you have to use bKohaColumnsUseNames or the column visibility won't work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Joubu. Owen, can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- This needs to be rebuilt on top of the other DataTables patches that are in the queue. Please ping me if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Bug 37219 depends on bug 37229, which changed state. Bug 37229 Summary: Table configuration listings for course reserves incorrect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37229 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174551|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184568&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes by the tidy script, so ignore whitespace when viewing the diff. The patch also includes some code changes to hide the copy number column if it contains no data. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |marie-luce.laflamme@inlibro | |.com --- Comment #12 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Patch doesn't apply. The radio button now has its own "Choose" column, which is a nice change. Most of the settings in the OPAC-hold table seem to work fine for showing or hiding fields, except for one thing. The 'Copy number' column doesn't appear, even when the setting is enabled and the items have a 952$t. I created a test record in case it helps. Please let me know if you need any more information or if I can help with anything else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184568|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185110&action=edit Bug 37219: In OPAC item holds, separate copy number from radio button and add table configuration This patch changes the way items are displayed during the process of placing a single or multiple item-level holds in the OPAC. The item-selection radio button is now in a separate column from copy number, and the columns can be configured. Note: This patch includes indentation changes by the tidy script, so ignore whitespace when viewing the diff. The patch also includes some code changes to hide the copy number column if it contains no data. To test, apply the patch and restart services. - If necessary, go to Administration -> Circulation and fine rules and enable item-level holds in one of the rules. - Log in to the OPAC and start the process of placing a hold on a title which falls under your configured circulation rule. - On the place hold page, click "Show more options" and "A specific item" to show the table of items. - The radio buttons and copy numbers should appear in separate columns. - Go to Administration -> Table settings -> OPAC -> opac_holds and change the table's configuration to hide one or more columns. - Return to the OPAC holds process and confirm that the table reflects your configuration changes. - Perform the same test with multiple holds (selecting multiple items in catalog search results). Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185111&action=edit Bug 37219: (follow-up) Send copy number flag to template This patch corrects opac-reserve.pl so that copy number information will be passed to the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185111|0 |1 is obsolete| | --- Comment #15 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Created attachment 185279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185279&action=edit Bug 37219: (follow-up) Send copy number flag to template This patch corrects opac-reserve.pl so that copy number information will be passed to the template. Signed-off-by: Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37219 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org