[Bug 21901] New: Improve performance for serial registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Bug ID: 21901 Summary: Improve performance for serial registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: frank.hansen@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Because two indexes are missing, the SQL searches in C4::Serials perform very slow. Since theres no indexes for subscription.biblionumber and serial.subscriptionid, the SQL server will do a full table scans on both tables, which takes a very long time, especially if you have 100,000 subscriptions and approximately one million series registered. To improve response time, at least two indexes are required. I will therefore suggest these two indexes to be built: alter table serial add index idx_serial_subscriptionid using btree (subscriptionid); alter table subscription add index idx_subscription_biblionumber (biblionumber); It's also strange that the subscriptionid in serial is a varchar(100). In subscriptions table, subscriptionid is an int. I think subscriptionid in serial should be an int for safe and for best performance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Maria <mbugz2@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbugz2@yahoo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96181&action=edit Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve performance for |Foreign keys are missing on |serial registration |the serials and | |subscriptions tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96181|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98177&action=edit Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like seeing foreign keys added.. works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary
Since it is theoretically possible that a delete was not completely executed somehow leaving some bad keys in the table, it would be useful to remove the entries and not assume they are not. Cannot be verified by one or two tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Inclined to think that could be a blocker. We dont want large installs fail on this step. Feel free to change the status again, well argumented ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #6)
Inclined to think that could be a blocker. We dont want large installs fail on this step. Feel free to change the status again, well argumented ;)
I let that kind of comment to get help on it, not to see people asking me to unlock the issue. We need to test it on a old and big production DB, as I said. I do not have one to try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
(In reply to Marcel de Rooy from comment #6)
Inclined to think that could be a blocker. We dont want large installs fail on this step. Feel free to change the status again, well argumented ;)
I let that kind of comment to get help on it, not to see people asking me to unlock the issue. We need to test it on a old and big production DB, as I said. I do not have one to try.
Yes, but what I am saying is that one such a test does not prove anything. If it does not contain referential errors, it goes fine. Does not prove that nobody else has such problems.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What do you suggest then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <marcelr> ashimema: did you test on a large production DB ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tested on 4 large clones of production Databases.. none of them failed in the way you are suggesting.. but it may not be a terrible idea to add a line for each foreign key addition to 'clean' the bad data. I did find that in a fair few cases that malformed date fields would crash the update... I'm not sure whether to fold in a check and clean for such fields into this patch or open another bug to be honest.. I think I'm inclined to fold it in here to ensure the DB update will actually run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98229&action=edit Bug 21901: (QA follow-up) Ensure consistent data before adding keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98229|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98231&action=edit Bug 21901: (QA follow-up) Ensure consistent data before adding keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Run against a series of large databases.. adding the additional security of the followup did not result in any discernible performance degradation of the update so I think it's a worthwhile addition. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As I said this morning on #koha, I do not think we should silently delete those rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
As I said this morning on #koha, I do not think we should silently delete those rows.
Instead of deleting we could look at setting to NULL. Not sure if it would be very valuable? We could dump the original serial tables to a backup file allowing a local developer to restore information; not sure if anyone would. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting to NULL leaves us with broken data and worse an avenue to new broken data being input. Personally, as I couldn't' find any cases where a delete would actually take place (and I went back to some koha versions many years old) and the data being deleted would lead to errors in the client as relations would be broken I feel it's justified to leave the delete in place... open to being countered as ever but I'd rather this didn't end up stuck in perpetuity as so many FK bugs do :'(. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I undertand this correctly the problem might be cases where there is incomplete data? like a subscription without subscription history? Or a serial entry with a link to a nonexisting subscription? We store the user's name in subscription... so if we are very strict we might not want to dump it to the file system to be forgotten about. If we set to null, we need to make the db structure more lenient... I guess dumping might be the best option. How likely is it those cases exist? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #19 from Frank Hansen <frank.hansen@ub.lu.se> --- Hi,
0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly.
2/ Make sure you can upgrade from a master install This step went well, no errors. I think it is good that orphaned entries is removed before creating the FK constraints. It turned out in our case there were data that were migrated from our previous system by mistake. So the subscription was actually deleted in the
Here in Lund we have tested your fix on a clone of our production DB with over 90000 subscriptions and the short story is that we are satisfied of what the fix accomplish. old system. So, we didn't lose any important data anyway.
3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB The fix does what it should. And the performance has also improved significantly which is important from my perspective.
4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB The fix does what it should. Works fine.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100384&action=edit Bug 21901: Add a warning if we removed entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have added a follow-up to display a warning message if entries are going to be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98177|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100545&action=edit Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98231|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100546&action=edit Bug 21901: (QA follow-up) Ensure consistent data before adding keys Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100384|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100547&action=edit Bug 21901: Add a warning if we removed entries Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This seems to cover all the bases to me now.. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- DELETE FROM serial WHERE biblionumber NOT IN (SELECT biblionumber FROM biblio) Wouldnt it be better to left join biblio here and check biblionumber is null in the where condition ? Same for another one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100545|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103122&action=edit Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100546|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103123&action=edit Bug 21901: (QA follow-up) Ensure consistent data before adding keys Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100547|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103124&action=edit Bug 21901: Add a warning if we removed entries Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103125&action=edit Bug 21901: (QA follow-up) Add a few NOT NULL constraints in dbrev We need to specify NOT NULL on subscription and -history as well. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103151&action=edit Bug 21901: (RM follow-up) Use TestBuilder to fix tests A few tests failed due to missing values for foreign key relationships. Switching to TestBuilder for data mocking resolves this elegantly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #34 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842 [Bug 27842] Incorrect biblionumber handling in serials subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- See bug 27842 - this potentially causes data loss during upgrades -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org