[Bug 11410] New: Cataloging search finds no results for searches with ampersands
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Bug ID: 11410 Summary: Cataloging search finds no results for searches with ampersands Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23614&action=edit Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org --- Comment #2 from Heather Braum <hbraum@nekls.org> --- I have followed this test plan, and can confirm the patch fixes this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Suzanne Fayle <sfayle@roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sfayle@roseman.edu --- Comment #3 from Suzanne Fayle <sfayle@roseman.edu> --- This is working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23614|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23722&action=edit Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Suzanne Fayle <sfayle@roseman.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23742&action=edit [PASSED QA] Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Suzanne Fayle <sfayle@roseman.edu> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described, passes all tests and QA script. Note: Because $query = $builtquery when the QueryParser is used, this problem is only visible when UseQueryParser is set to "Don't try". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23722|0 |1 is obsolete| | CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org