[Bug 28166] New: optionally add marc fields to authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Bug ID: 28166 Summary: optionally add marc fields to authority search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: koha@trust-box.at QA Contact: testopia@bugs.koha-community.org create feature + configuration similar to "AdditionalFieldsInZ3950ResultSearch" for Authorities "AdditionalFieldsInZ3950AuthResultSearch" as far as I see sub _add_custom_field_rowdata from package C4::Breeding; could be reused if the the code is reflowed a little bit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |koha@trust-box.at |ity.org | CC| |koha@trust-box.at Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #1 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 120139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120139&action=edit patches Breeding.pm, cataloguing.pref, z3950_auth_search.tt adds new syspref "AdditionalFieldsInZ3950ResultAuthSearch" for authorities analogous to AdditionalFieldsInZ3950ResultSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, some hopefully helpful comments :) Please take a look at the coding guidelines. We only capitalize the first word, so it would be "Additional fields" etc. Easy to fix, just something to keep in mind. Is this meant to be ready for testing? Then don't forget to switch to "Needs signoff" as this will alert the testers and get it in the right queue. But in order for them to be able to test with our tools, we'd need a patch file. Using git bz is really helpful here: https://wiki.koha-community.org/wiki/Git_bz_configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #3 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 120154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120154&action=edit Bug 28166: optionally add marc fields to authority search this patch creates a new syspref: AdditionalFieldsInZ3950AuthResultSearch, analogous to AdditionalFieldsInZ3950ResultSearch if this syspref is populated with with comma separated marc fields (eg '100, 400') those fields are displayed in in the z3950_auth_search C4/Breeding.pm was slightly modified to be able to use "_add_custom_field_rowdata" to add the additonal fields koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt was modified to display the "Addtional fields" conditionally testing: - add set values to AdditionalFieldsInZ3950AuthResultSearch the should show up in the auth_search - AdditionalFieldsInZ3950ResultSearch should also be tested as it is also concerned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking much better, thx! But there are lots of unrelated and breaking changes in this patch I am afraid. :( The 0/1 for prefs is correct in master and should not be changed (see bug 22824). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120154|0 |1 is obsolete| | --- Comment #5 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 120155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120155&action=edit Bug 28166: optionally add marc fields to authority search this patch creates a new syspref: AdditionalFieldsInZ3950AuthResultSearch, analogous to AdditionalFieldsInZ3950ResultSearch if this syspref is populated with with comma separated marc fields (eg '100, 400') those fields are displayed in in the z3950_auth_search C4/Breeding.pm was slightly modified to be able to use "_add_custom_field_rowdata" to add the additonal fields koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt was modified to display the "Addtional fields" conditionally testing: - add set values to AdditionalFieldsInZ3950AuthResultSearch the should show up in the auth_search - AdditionalFieldsInZ3950ResultSearch should also be tested as it is also concerned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #6 from Mark Hofstetter <koha@trust-box.at> --- I've redone the patch, plz check again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12747 Summary|optionally add marc fields |Optionally add MARC fields |to authority search |to authority search Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 [Bug 12747] Add configurable extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120139|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, something is not quite right with the patch set. The first file is not a real patch file, the second only won't apply - I assume they are both needed from looking at the diffs, but as the first has the wrong format, this is not working. Also, the second file contains a lot of unrelated changes in the yaml file. A change to the sysprefs.sql file is missing (https://wiki.koha-community.org/wiki/System_Preferences) Can you provide one cleaned up patch file for master with all required changes? -------------- Apply? [(y)es, (n)o, (i)nteractive] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2711, in <module> applied = do_apply(bug_ref) File "/usr/local/bin/git-bz", line 1820, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #8 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 148749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148749&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148749|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148755&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148755|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148778&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- This looks neat, I like the feature, the patches need some cleanup Must fix: - the patch adds the function _add_rowdata, I think it's a rebase leftover? - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine - delete the commented lines from the code Could fix: - the routine should take a hashref, the more parameters we have, the nicer it i s to have them named -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #12 from Mark Hofstetter <koha@trust-box.at> --- Must fix: - the patch adds the function _add_rowdata, I think it's a rebase leftover? => OK, done - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine => I really don't understand this one, "_handle_one_result" is only used for bibs so nothing changes here - delete the commented lines from the code => OK, done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148778|0 |1 is obsolete| | --- Comment #13 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 150590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150590&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150590|0 |1 is obsolete| | --- Comment #14 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 150594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150594&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #15 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 150595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150595&action=edit removed comments and _add_rowdata -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150595|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150596&action=edit Bug 28166: Removed comments and _add_rowdata -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (Adjusted the commit title to make the QA script happy) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Mark Hofstetter from comment #12)
Must fix: - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine
=> I really don't understand this one, "_handle_one_result" is only used for bibs so nothing changes here
_handle_one_result calls _add_custom_field_rowdata Previously _add_custom_field_rowdata fetched the system preference 'AdditionalFieldsInZ3950ResultSearch' After these patches it expects to receive the additional fields in a parameter, we need to update the call C4/Biblio.pm: 317 $row = _add_custom_field_rowdata($row, $marcrecord); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150601&action=edit Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150594|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153431&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Bug 28166: Removed comments and _add_rowdata Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored Bug 28166: (QA follow-up) Fix rebase issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Attachment #150596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Had to rebase. Squashed it too to remove some developing cruft. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We need some tests still. Breeding.t now fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- WARN C4/Breeding.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 217, now: 218) WARN installer/data/mysql/atomicupdate/bug_28166.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) Since this was written before cutoff date, I wouldnt care too much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22492 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153431|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156166&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Bug 28166: Removed comments and _add_rowdata Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored Bug 28166: (QA follow-up) Fix rebase issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156167&action=edit Bug 28166: (QA follow-up) Fix and tidy tests and code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 19844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156166|0 |1 is obsolete| | Attachment #156167|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156550&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Bug 28166: Removed comments and _add_rowdata Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored Bug 28166: (QA follow-up) Fix rebase issue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156551&action=edit Bug 28166: (QA follow-up) Fix and tidy tests and code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase ASAP. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156550|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157646&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Bug 28166: Removed comments and _add_rowdata Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored Bug 28166: (QA follow-up) Fix rebase issue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156551|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157647&action=edit Bug 28166: (QA follow-up) Fix and tidy tests and code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting Keywords| |release-notes-needed --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With the new system release notes| |preference | |`AdditionalFieldsInZ3950Res | |ultAuthSearch` it is now | |possible to display | |additional information from | |the MARC record in the | |authority Z39.50/SRU search | |result lists. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Rasa Satinskiene contact| | CC| |rasa.satinskiene@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/809 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #34 from Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> --- Manual updated. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org