[Bug 30301] New: Add a system preference to allow specifying the patron expiration notices as mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Bug ID: 30301 Summary: Add a system preference to allow specifying the patron expiration notices as mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This enhancement will add a new system preference / control to allow specifying that the patron expiration notification is mandatory, and enforce selection of one of the transport options in the messaging preferences (radio button vs checkboxes) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Depends on| |30300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30300 [Bug 30300] Add patron expiration email to patron messaging preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jake.deery@ptfs-europe.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think the work in bug 30300 might now cover this already - the expiry notice is added to the patron category level messaging preferences and this enforces the selection when creating a new patron of that category. Let me know if there is a different requirement for this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's the opposite. With the work on 30300 it will be exposed in the OPAC and patrons will be able to remove the notice from their messaging settings. This bug only makes sense with that change in mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- So we would need a flag in the category to prevent patron's from changing it, I'll have a think about that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #3)
So we would need a flag in the category to prevent patron's from changing it, I'll have a think about that
Maybe a global switch would be OK too - Nick might know where this came from originally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175086&action=edit Bug 30301: Add a new column to enforce the expiry notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175087&action=edit Bug 30301: DBIC file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175088&action=edit Bug 30301: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175089&action=edit Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I've added a flag at the patron category level to enforce the notice. Rather than adding a messaging preference for every patron in that category when the flag is active, the system checks for the flag and then for any patron that doesn't have an expiry messaging preference set, it will add a notice for that patron based on their main contact method, defaulting to print if that isn't set. If the flag is active, patrons also won't be able to amend their messaging preference for the expiry notice if they are in that category Hope that makes sense and meets the requirement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lisette@bywatersolutions.co | |m, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175086|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175526&action=edit Bug 30301: Add a new column to enforce the expiry notice Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175087|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175527&action=edit Bug 30301: DBIC file Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175088|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175528&action=edit Bug 30301: Update templates Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175089|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175529&action=edit Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175526|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181102&action=edit Bug 30301: Add a new column to enforce the expiry notice Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175527|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181103&action=edit Bug 30301: DBIC file Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175528|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181104&action=edit Bug 30301: Update templates Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175529|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181105&action=edit Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181106&action=edit Bug 30301: Revert "Bug 32216: Add print notices to membership_expiry.pl" This reverts commit 3040f46d5efc73454e6a1558891a65ae8b0ea2c0. Bug 30300 adds a patron messaging preference for the expiration notice and abstracts this logic into queue_notice Bug 32216 removes this call to enable print notice functionality but this would be handled already by queue_notice based on the patron's messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181107&action=edit Bug 30301: Restore check for mandatory notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181108&action=edit Bug 30301: Allow for forcing of print notices Although we're reverting 32216, we still want to be able to force print notices as per the original intent. This patch adds that into queue_notices, rather than in the cronjob Co-authored-by: Jake Deery <jake.deery@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181102|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182152&action=edit Bug 30301: Add a new column to enforce the expiry notice Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181103|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182153&action=edit Bug 30301: DBIC file Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181104|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182154&action=edit Bug 30301: Update templates Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181105|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182155&action=edit Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181106|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182156&action=edit Bug 30301: Revert "Bug 32216: Add print notices to membership_expiry.pl" This reverts commit 3040f46d5efc73454e6a1558891a65ae8b0ea2c0. Bug 30300 adds a patron messaging preference for the expiration notice and abstracts this logic into queue_notice Bug 32216 removes this call to enable print notice functionality but this would be handled already by queue_notice based on the patron's messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181107|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182157&action=edit Bug 30301: Restore check for mandatory notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181108|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182158&action=edit Bug 30301: Allow for forcing of print notices Although we're reverting 32216, we still want to be able to force print notices as per the original intent. This patch adds that into queue_notices, rather than in the cronjob Co-authored-by: Jake Deery <jake.deery@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182527&action=edit Bug 30301: (QA follow-up) Restore correct terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182529&action=edit Bug 30301: (QA follow-up) Restore correct terminology and add to columns settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182152|0 |1 is obsolete| | --- Comment #30 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182530&action=edit Bug 30301: Add a new column to enforce the expiry notice Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182153|0 |1 is obsolete| | --- Comment #31 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182531&action=edit Bug 30301: DBIC file Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182154|0 |1 is obsolete| | --- Comment #32 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182532&action=edit Bug 30301: Update templates Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182155|0 |1 is obsolete| | --- Comment #33 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182533&action=edit Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes Signed-off-by: Hanna Leiker <tech.hanna@salinapublic.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182156|0 |1 is obsolete| | --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182534&action=edit Bug 30301: Revert "Bug 32216: Add print notices to membership_expiry.pl" This reverts commit 3040f46d5efc73454e6a1558891a65ae8b0ea2c0. Bug 30300 adds a patron messaging preference for the expiration notice and abstracts this logic into queue_notice Bug 32216 removes this call to enable print notice functionality but this would be handled already by queue_notice based on the patron's messaging preferences Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182157|0 |1 is obsolete| | --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182535&action=edit Bug 30301: Restore check for mandatory notice Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182158|0 |1 is obsolete| | --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182536&action=edit Bug 30301: Allow for forcing of print notices Although we're reverting 32216, we still want to be able to force print notices as per the original intent. This patch adds that into queue_notices, rather than in the cronjob Co-authored-by: Jake Deery <jake.deery@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182529|0 |1 is obsolete| | --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182537&action=edit Bug 30301: (QA follow-up) Restore correct terminology and add to columns settings Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182538&action=edit Bug 30301: (QA follow-up) Restore terminology in messaging preferences Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase or push patches to a remote branch based on recent main: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30301: (QA follow-up) Restore correct terminology error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt). error: could not build fake ancestor Patch failed at 0001 Bug 30301: (QA follow-up) Restore correct terminology hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-30301-QA-follow-up-Restore-correct-terminology-90u9zgfz.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Patch needed obsoleting, should apply fine now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was hoping that this would allow to "restore" the previous behavior where libraries have used the SQL option of the CLI script for some patron categories, but not others without giving patrons the options to set messaging preferences i the OPAC. But this is a little different again: Enforce means that a print notice will be forced when email is not selected. So there will always be a notice, if I understand correctly. Right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a system preference to |Add an option to specify |allow specifying the patron |the patron expiration |expiration notices as |notices as mandatory by |mandatory |patron category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This broke tests please fix urgently! t_db_dependent_api_v1_patron_categories_t.list() tests (719) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182645&action=edit Bug 30301: (follow-up) Fix API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows to configure by release notes| |patron category if a user | |is allowed to opt-out of | |the patron account | |expiration notice. If the | |noticed is enforced, the | |patron can only pick | |between the available | |message transport options, | |but not deactivate the | |notice entirely. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40294 [Bug 40294] Mandatory patron expiration notice is not sent if patron does not have a primary contact method defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40646 [Bug 40646] ‘Patron account expiry’ message selections un-set when switching 'Enforce patron account expiry notice' from Yes to No -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42538 [Bug 42538] Patron account expiry message preference is shown and editable when creating new patron in category for which expiry notice is enforced -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42539 [Bug 42539] When patron category set to Enforce patron account expiry notice, notices are not sent to all patrons in that category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Danielle M. <dmeininger591@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmeininger591@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30301 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42961 [Bug 42961] Option for no mail (-n) no longer functional in membership_expiry cron -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org