[Bug 26420] New: Overdue notices script does not care about borrower's language, always takes default template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Bug ID: 26420 Summary: Overdue notices script does not care about borrower's language, always takes default template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org Since Bug 17762, it is possible to translate notices. But script misc/cronjobs/overdue_notices.pl does not test if preference system is active and does not call C4::Letters::getletter with $lang parameter So if preference system is active and default template not filled because you want translated notices, their is no notice generated at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17762 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109837&action=edit Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109837|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110036&action=edit Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110036|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110123&action=edit Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05, released in| |19.11.11 CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.05, |20.11.00, 20.05.05, released in|19.11.11 |19.11.11, 19.05.16 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #9 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Shouldn't we still fall back to the default language if a tranlation is missing? I reported bug 28487. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andreas Jonsson from comment #9)
Shouldn't we still fall back to the default language if a tranlation is missing? I reported bug 28487.
I think you are correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 [Bug 28487] Overdue_notices does not fall back to default language -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org