[Bug 8050] New: debian/build-git-snapshot should warn user if it fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Priority: P5 - low Change sponsored?: --- Bug ID: 8050 Assignee: robin@catalyst.net.nz Summary: debian/build-git-snapshot should warn user if it fails Severity: normal Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Packaging Product: Koha The script debian/build-git-snapshot returns success even if the package building fails. Automating package build requires some sort of feedback if the package build fails, preferably a non-success return value for the debian/build-git-snapshot script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37414&action=edit Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Robin, do you think this patch could be useful for you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- I haven't had a look at the detail, but based on the subject I think it's a good thing. I'll look closer soon I hope. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37414|0 |1 is obsolete| | --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 37425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37425&action=edit Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Made a minor change to print the command, add a newline. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- Jonathan, if you can give my changes a quick review then that'll be enough for me to consider it passed QA too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37425|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37453&action=edit [PASSED QA] Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Made a minor change to print the command, add a newline. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Robin Sheat from comment #5)
Jonathan, if you can give my changes a quick review then that'll be enough for me to consider it passed QA too.
Good for me :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org