[Bug 7228] New: can't order more than 1 when importing all from staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Bug #: 7228 Summary: can't order more than 1 when importing all from staged file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com Created attachment 6314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6314 error If you choose to import all from a staged file you can only have 1 items per line item - you cannot at this time modify the quantity, if you try by clicking on modify it says you can't do it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 17521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17521&action=edit proposed patch Hello Nicole, I don't know if my patch responds to your problem. Because it depends on the syspref 'AcqCreateItem'. If not I'll create a new bug report. Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois@bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17521|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 17522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17522&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Patch made for Rennes 2. I will test it ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Christophe, your patch is made for AcqCreateItem = on receive. Don't you think it could also be useful for ppl using AcqCreateItem = on cataloguing? For me the current behavior is good only if you create items when you order... M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hi Mathieu, no, in fact the patch shows the warning, and prohibits to add items in one case => AcqCreateItem = placing.. So, about the other two cases there is no warning, no prohibition. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Sorry, I did not read it well. I'm going to test. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17522|0 |1 is obsolete| | --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 17678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17678&action=edit [PATCH 1/1][SIGNED OFF] bug 7228 : can't add items in an order with Modify -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #7)
Created attachment 17678 [details] [review] [PATCH 1/1][SIGNED OFF] bug 7228 : can't add items in an order with Modify
hmmm, i think we need a test plan here, so qa-team can test this properly... can we get a test plan please, before QA? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Here is the test I made for signing off : after applying the patch - syspref AcqCreateItem : create items on receiving - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on cataloguing - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on receiving - in a basket, create an order (click on "add" to add an item => quantity = 1) - save the order - reopen the order - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message) => the behavior is the same as before the patch M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- wrong copy/paste... Here is the test I made for signing off : after applying the patch - syspref AcqCreateItem : create items on RECEIVING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on CATALOGING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on ORDERING - in a basket, create an order (click on "add" to add an item => quantity = 1) - save the order - reopen the order - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message) => the behavior is the same as before the patch M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17831&action=edit [PASSED QA] Bug 7228: can't add items in an order with Modify We have a message if we want to add items and we can't add, substract only. It's ok if we choose to create items on ordering, in this case koha can't add items, just substract and in this case we have to delete manually the items(s) in the catalog. But if via the syspref AcqCreateItem we choose to create items when receiving this limitation is not usefull The patch just checks if the syspref AcqCreateItem is on 'ordering' if not the message is not shown and we can add items Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Here is the test I made for signing off : after applying the patch - syspref AcqCreateItem : create items on RECEIVING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on CATALOGING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on ORDERING - in a basket, create an order (click on "add" to add an item => quantity = 1) - save the order - reopen the order - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message) => the behavior is the same as before the patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copied test plan from bug report. Template only change deactivating the Javascript that blocks you from changing the quantity when AcqCreateItem is set to something else than 'ordering'. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17678|0 |1 is obsolete| | Attachment #17831|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17832&action=edit [PASSED QA] Bug 7228: can't add items in an order with Modify We have a message if we want to add items and we can't add, substract only. It's ok if we choose to create items on ordering, in this case koha can't add items, just substract and in this case we have to delete manually the items(s) in the catalog. But if via the syspref AcqCreateItem we choose to create items when receiving this limitation is not usefull The patch just checks if the syspref AcqCreateItem is on 'ordering' if not the message is not shown and we can add items Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Here is the test I made for signing off : after applying the patch - syspref AcqCreateItem : create items on RECEIVING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on CATALOGING - in a basket, create an order (quantity = 1) - save the order - reopen the order - change the quantity (2 instead of 1) - save the order => changing quantity was not possible before the patch - syspref AcqCreateItem : create items on ORDERING - in a basket, create an order (click on "add" to add an item => quantity = 1) - save the order - reopen the order - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message) => the behavior is the same as before the patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copied test plan from bug report. Template only change deactivating the Javascript that blocks you from changing the quantity when AcqCreateItem is set to something else than 'ordering'. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de Patch complexity|Small patch |--- --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch works and solves an existing problem, so I am passing QA on it. What worries me a little is that there is no way to know if the AcqCreateItem setting was changed between creating the order initially and trying to modify it. Maybe a better way would be to check if there are actually items linked to this order to determine if you can add more or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #14 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Katrin, you are right, my patch is just a quick way to solve only a part of the problem. I haven't thought at the case someone change the syspref after creating a line. Your idea about looking for items created in aqorders_items would be more safe. But I think it would be better to add to this page the creation of each new item, the same job done when you create the order. But it needs more time to do so. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Yes, maybe it could be improved later, but at present all libraries using AcqCreateItem = on receive and importing records from a vendor are very worried, so Christophe's patch will be a good thing for them. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christophe and Mathieu, no worries - I agree that this patch should go in as it is now. It might be worthwile to refactor all this code sometime, but certainly not shortly before a major release :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien@koha-fr.org |christophe.croullebois@bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #19 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 18129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18129&action=edit patch rebased for 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #20 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 18130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18130&action=edit patch rebased for 3.8.x Hi Chris, I have made two patches for 3.8 and 3.10. I have added a line in the comment to distinguish each one thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Thanks, will test and push them now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8803 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #23 from Nicole C. Engard <nengard@gmail.com> --- The problem I reported was the one thing that this patch doesn't fix: - syspref AcqCreateItem : create items on ORDERING - in a basket, create an order (click on "add" to add an item => quantity = 1) - save the order - reopen the order - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message) => the behavior is the same as before the patch If I want to order from a staged file I should be able to add multiple copies even if I'm doing the item at the time of ordering. Otherwise what's the benefit? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, maybe you could open a new bug for this and link them? I know that this was your bug and the fix didn't fix your problem, but it might be less confusing. Bugs with lots of comments are hard to work with and we could state clearly that the next development will be for AcqCreateItem = on order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10501 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #25 from Nicole C. Engard <nengard@gmail.com> --- http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10501 created -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org