[Bug 29759] New: Revert credit when cancelling an article request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug ID: 29759 Summary: Revert credit when cancelling an article request Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 27946 adds the ability to charge a fee when the patron makes an article request. This development will make the fee be reverted. Reversible credits will generate a refund. Methods introduced by bug 29757 will be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29757, 27946 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128874&action=edit Bug 29759: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128875&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Revert credit when |Refund credit when |cancelling an article |cancelling an article |request |request CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28656 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128874|0 |1 is obsolete| | Attachment #128875|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 129162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129162&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 129163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129163&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129162|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129181&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129163|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129182&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- hmm.. I'm still not 100% sure of this. Scenario 1 1. Article request placed, fee added 2. Article request cancelled, fee cancelled (currently appears as a refund) Scenario 2 1. Article request placed, fee added 2. Patron pays full amount 3. Article request cannot be fulfilled so is cancelled 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' rather than the original 'charge' ? Scenario 3 1. Article request placed, fee added 2. Patron pays some amount 3. Article request is cancelled 4. Patron is 'refunded' the amount paid (but it links to the charge, not the payment) 5. Patron is also 'refunded' the outstanding amount (again, links to the charge) I think these could end up rather confusing in the accounts screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This gives us an opportunity to create something consistent for lost item charge refunds too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #7)
hmm.. I'm still not 100% sure of this.
Scenario 1 1. Article request placed, fee added 2. Article request cancelled, fee cancelled (currently appears as a refund)
Scenario 2 1. Article request placed, fee added 2. Patron pays full amount 3. Article request cannot be fulfilled so is cancelled 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' rather than the original 'charge' ?
Scenario 3 1. Article request placed, fee added 2. Patron pays some amount 3. Article request is cancelled 4. Patron is 'refunded' the amount paid (but it links to the charge, not the payment) 5. Patron is also 'refunded' the outstanding amount (again, links to the charge)
I think these could end up rather confusing in the accounts screen.
Nice catch! I think it is clear this needs to point to the payment! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + is( abs $patron->account->balance, $payed_amount, 'The patron has been refunded the right value' ); Frowning by intuition. abs ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still looking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129297&action=edit Bug 29757: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129298&action=edit Bug 29759: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129297|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 129297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129297 Bug 29757: (QA follow-up) Remove abs from the test Wrong bug number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #9)
(In reply to Martin Renvoize from comment #7)
hmm.. I'm still not 100% sure of this.
Scenario 1 1. Article request placed, fee added 2. Article request cancelled, fee cancelled (currently appears as a refund)
Scenario 2 1. Article request placed, fee added 2. Patron pays full amount 3. Article request cannot be fulfilled so is cancelled 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' rather than the original 'charge' ?
Scenario 3 1. Article request placed, fee added 2. Patron pays some amount 3. Article request is cancelled 4. Patron is 'refunded' the amount paid (but it links to the charge, not the payment) 5. Patron is also 'refunded' the outstanding amount (again, links to the charge)
I think these could end up rather confusing in the accounts screen.
Nice catch! I think it is clear this needs to point to the payment!
Still looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Martin, what about scenario 4: Fee charged 10 Paid 2 Paid 3 Cancelled Now we cannot link to "the payment" because we have two payments. We can split the credit because we want to link to all individual payments. But I feel that does not make much sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Bit out of scope, but anyway: When I have an AR fee, I pay an amount, and then void the payment on Transactions, I can afterwards issue a refund on the voided credit. Should that really be possible? Similarly, I can do Void payment on the Refund. Huh? Then i can click Pay on Payment from library to patron. Huh? Not sure if we should allow all these actions which can really mess up the whole balance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #16)
Martin, what about scenario 4:
Fee charged 10 Paid 2 Paid 3 Cancelled
Now we cannot link to "the payment" because we have two payments. We can split the credit because we want to link to all individual payments. But I feel that does not make much sense?
Having the impression that the argument of confusing transactions definitely applies on voiding individual offsets here. I would go for the cumulative credit that Tomas implemented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And as a final note: If we could rework $accountline->cancel someday, we could perhaps move this code out of the article requests domain. $debit_accountline->cancel(); Cancel a charge. It will mark the debit as 'cancelled' by updating its status to 'CANCELLED'. Charges that have been fully or partially paid cannot be cancelled. Since we can void payments as well, it would be nice to allow cancelling of partially paid debit account lines. Moving the add_credit/reduce thing to where it really belongs. In the meantime this looks good enough to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129181|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129302&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129182|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129303&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129298|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129304&action=edit Bug 29759: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Fridolin: push this one too it belongs to the AR series (on top of 29757) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oupsy looks like it breaks the test suite, see : https://jenkins.koha-community.org/job/Koha_Master_D10/519/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- t/db_dependent/Letters/TemplateToolkit.t .. 5/28 # No tests run! # Failed test 'No tests run for subtest "AR_*"' # at t/db_dependent/Letters/TemplateToolkit.t line 408. # Looks like you planned 8 tests but ran 2. # Looks like you failed 1 test of 2 run. t/db_dependent/Letters/TemplateToolkit.t .. 24/28 # Failed test 'regression tests' # at t/db_dependent/Letters/TemplateToolkit.t line 1028. Account line 24 is not a debit# Looks like your test exited with 11 just after 24. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130093&action=edit Bug 29759: (follow-up) Fix TemplateToolkit.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130093|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130094&action=edit Bug 29759: (follow-up) Fix TemplateToolkit.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130095&action=edit Bug 29759: (follow-up) Fix api/v1/article_requests.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130095|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130096&action=edit Bug 29759: (follow-up) Fix api/v1/article_requests.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- New patches pushed to master : b62fcec5cc Bug 29759: (follow-up) Fix api/v1/article_requests.t 8c80db886a Bug 29759: (follow-up) Fix TemplateToolkit.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug 29759 depends on bug 27946, which changed state. Bug 27946 Summary: Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug 29759 depends on bug 29757, which changed state. Bug 29757 Summary: Add filter_by_non_reversible/reversible methods for offsets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org