[Bug 25363] New: Merge common.js with staff-global.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Bug ID: 25363 Summary: Merge common.js with staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In the staff interface templates we include both staff-global.js and common.js globally. I don't see any reason why they need to be two files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104280&action=edit Bug 25363: Merge common.js with staff-global.js This patch merges the contents of common.js with staff-global.js. Both are included globally in the staff interface, and there doesn't seem to be any reason to require that the user downloads two different JavaScript files. To test, apply the patch and perform a catalog search in the staff client. View the detail page for a title in the search results. On the detail page you should see navigation controls in the sidebar for browsing through search results. Confirm they work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104280|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 104388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104388&action=edit Bug 25363: Merge common.js with staff-global.js This patch merges the contents of common.js with staff-global.js. Both are included globally in the staff interface, and there doesn't seem to be any reason to require that the user downloads two different JavaScript files. To test, apply the patch and perform a catalog search in the staff client. View the detail page for a title in the search results. On the detail page you should see navigation controls in the sidebar for browsing through search results. Confirm they work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104388|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105751&action=edit Bug 25363: Merge common.js with staff-global.js This patch merges the contents of common.js with staff-global.js. Both are included globally in the staff interface, and there doesn't seem to be any reason to require that the user downloads two different JavaScript files. To test, apply the patch and perform a catalog search in the staff client. View the detail page for a title in the search results. On the detail page you should see navigation controls in the sidebar for browsing through search results. Confirm they work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 [Bug 19290] Browse selected biblios - Staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org