[Bug 16048] New: Making notices actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Bug ID: 16048 Summary: Making notices actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48979&action=edit Bug 16048: Making notices actions buttons To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48979|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48980&action=edit Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, it is better to define a class name for the td and set a style in the css file: Something like: <td class="actions"> .actions { white-space: nowrap; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16036 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48980|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49007&action=edit [SIGNED-OFF] Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have a couple of corrections in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49008&action=edit Bug 16048 [Follow-up] Making notices actions buttons This followup adds a "td.actions" style with "white-space:nowrap" and replaces the inline styles. Also modified is the way non-sorting table columns are defined. This corrects a problem with non-sortable columns introducted by the previous patch's column changes. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Notices and confirm that even at narrow browser widths the "Edit" and "Delete" buttons stay side by side. - Confirm that all columns are sortable except "Copy notice" and "Actions." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49007|0 |1 is obsolete| | Attachment #49008|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49010&action=edit Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have a couple of corrections in a follow-up. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49011&action=edit Bug 16048 [Follow-up] Making notices actions buttons This followup adds a "td.actions" style with "white-space:nowrap" and replaces the inline styles. Also modified is the way non-sorting table columns are defined. This corrects a problem with non-sortable columns introducted by the previous patch's column changes. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Notices and confirm that even at narrow browser widths the "Edit" and "Delete" buttons stay side by side. - Confirm that all columns are sortable except "Copy notice" and "Actions." Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16048 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org