[Bug 12114] New: Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Bug ID: 12114 Summary: Reports web service JSON output has an encoding problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To reproduce: - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report .../cgi-bin/koha/svc/report?id=1 - verify the umlaut displays wrong - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27333&action=edit Bug 12114: Fix encoding problem with reports JSON web service (opac) - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report <OPAC BaseURL/cgi-bin/koha/svc/report?id=1 - verify the umlaut displays not correctly - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly - apply patch - verify umlaut now displays correctly from the beginning Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27334&action=edit Bug 12114: Fix encoding problem with reports JSON web service (staff) Repeat tests from first patch, but this time, access the report with your staff client base URL. <Staff BaseURL>/cgi-bin/koha/svc/report?id=<reportid> Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 27360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27360&action=edit [Signed-off] Bug 12114: Fix encoding problem with reports JSON web service (opac) - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report <OPAC BaseURL/cgi-bin/koha/svc/report?id=1 - verify the umlaut displays not correctly - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly - apply patch - verify umlaut now displays correctly from the beginning Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 Followed test plan. Result as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27333|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 27361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27361&action=edit [Signed-off] Bug 12114: Fix encoding problem with reports JSON web service (staff) Repeat tests from first patch, but this time, access the report with your staff client base URL. <Staff BaseURL>/cgi-bin/koha/svc/report?id=<reportid> Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 Followed test plan. Result as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Patch uses JSON::XS which isn't in our list of dependencies. It may not be needed though. JSON has the same subroutine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #5)
Patch uses JSON::XS which isn't in our list of dependencies. It may not be needed though. JSON has the same subroutine.
It appears that both JSON:PP and JSON:XS support encode_json. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #6)
(In reply to Kyle M Hall from comment #5)
Patch uses JSON::XS which isn't in our list of dependencies. It may not be needed though. JSON has the same subroutine.
It appears that both JSON:PP and JSON:XS support encode_json.
I have verified encode_json works just fine using both PP and XS versions of JSON. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27360|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27619&action=edit Bug 12114: Fix encoding problem with reports JSON web service (opac) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27361|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27620&action=edit Bug 12114: Fix encoding problem with reports JSON web service (staff) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27621&action=edit Bug 12114 [QA Followup] - Use JSON instead of JSON::XS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Galen for providing the solution :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org