http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 31123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31123&action=edit Bug 12811 - Patron 'Details' and 'Check out' pages not working properly for staff users which don't have renewal override permissions In case when the staff user doesn't have (circulate) -> (override_renewals) permission granted, this code part var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; in circ/circulation.tt and members/moremember.tt leads to javascript error, because TT statement evaluates to empty string. To reproduce: - set AllowRenewalLimitOverride syspref to "Don't allow" (this step is possibly redundant / not quite relevant), - for testing purposes, log in as some (sample) staff user whitch does not have permission granted for "(override_renewals) Override blocked renewals", - have a look at some patron accounts (preferably, ones with 1+ check-out), observe that page layout is incorrect in "Check Out" and "Details" tab. To test: - apply patch, - retest and ensure that this issue is no longer reproductible, - make sure that there are no regressions of any kinds regarding renewal override permission for staff users (i.e, that it still works like intended). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- *** Bug 12878 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31197|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31439&action=edit [PASSED QA] Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions In case when the staff user doesn't have (circulate) -> (override_renewals) permission granted, this code part var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; in circ/circulation.tt and members/moremember.tt leads to javascript error, because TT statement evaluates to empty string. To reproduce: - set AllowRenewalLimitOverride syspref to "Don't allow" (this step is possibly redundant / not quite relevant), - for testing purposes, log in as some (sample) staff user whitch does not have permission granted for "(override_renewals) Override blocked renewals", - have a look at some patron accounts (preferably, ones with 1+ check-out), observe that page layout is incorrect in "Check Out" and "Details" tab. To test: - apply patch, - retest and ensure that this issue is no longer reproductible, - make sure that there are no regressions of any kinds regarding renewal override permission for staff users (i.e, that it still works like intended). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 --- Comment #6 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Kyle M Hall from comment #5)

Just an fyi, but I believe AllowRenewalLimitOverride should actually be Koha.Preference('AllowRenewalLimitOverride'). My patch ( in the duplicate bug ) resolves this issue.

I agree it would be better to use Koha.Preference() in both affected templates, but patch in bug 12878 appears to be incomplete: - circ/circulation.tt: renewal override is not working properly with this patch applied (due to missing [% USE Koha %] ?), - Koha.Preference() call is not being used in patched members/moremember.tt - any particular reason to treat this template differently then circ/circulation.tt? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12878 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.