http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-06 17:54:38 UTC --- Created attachment 6607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6607 Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-12-06 17:58:47 UTC --- Created attachment 6608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6608 Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea <wizzyrea@gmail.com> Verified tests 1-3, looks good to me. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6608|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 05:52:05 UTC --- Created attachment 6825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6825 Bug 7324: Show alternate email as mailto: / hide labels when field is empty UPDATE 2011-12-15 Fixed wrong div that broke the patron account display. Thank you Paul for catching this! Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea <wizzyrea@gmail.com> Verified tests 1-3, looks good to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 09:36:15 UTC --- QA comment: this time everything is OK prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok passed QA Note: that would be cool to hide all empty fields, like the ones in alternate addess and alternative contact. But this is a 1st step. patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 10:48:50 UTC --- I think for core informations, it must be displayed even if it's empty (address, phone, email), but for other informations (alternate), it can be hidden. The patch about displaying values in forms or not is related to data entry only if i'm not mistaking. So those patches are related... by completing what the other do. Plus you may want to have alternate address entered when you need it, but, when it's not entered, you may want not to display entries. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.