[Bug 25393] New: Create separate No Automatic Renewal Before rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Bug ID: 25393 Summary: Create separate No Automatic Renewal Before rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Koha currently applies the No Renewal Before value to both manual and automatic renewal. Libraries that use a mix of manual and automatic renewal often don't want the same behavior between them - they want manual renewal to be possible earlier in the checkout even if automatic renewal doesn't happen until closer to the due date. We could address this by maintaining separate No Renewal Before values. For what it's worth, we already acknowledge this possibility when leaving No Renewal Before blank. For a manual renewal, no value in No Renewal Before allows renewal immediately. For an automatic renewal, no value in No Renewal Before does not allow renewal until the due date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25096 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 kate <ksheehan@stratfordlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksheehan@stratfordlibrary.o | |rg --- Comment #1 from kate <ksheehan@stratfordlibrary.org> --- Strong agreement on this! We are currently struggling with autorenewal - we left "No Renewal Before" blank to keep the Never Autorenew people happy but now autorenew people are getting a glitchy notice after the autorenew notice and they're confused. We're going to try tipping the balance back to irritating the Never Autorenew people but I'd love to see this development happen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create separate No |Create separate 'no |Automatic Renewal Before |automatic renewal before' |rule |rule -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34526 [Bug 34526] Add override options to checkout renewal endpoint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Testing Plan 1. Ensure that there is a new column in the circulation and rule matrix for "No Automatic Renewal Before" 2. To test this process, a few rules will need to be tested to ensure that staff/patrons have the option to renew - even if the item is set to auto-renewal. 3. Use values such as No renewal before= 2 and No Auto Renewal = 3 4. Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew. 5. Try values such as No Renewal before =2 and No Auto Renewal =1, Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew. 6 Now go to the SCO and make sure the patron can renew items that are eligible to renew and if not, make sure patrons can see that they are scheduled to auto-renew. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154533&action=edit Bug 25393: Add new noautorenewalbefore circulation rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154534&action=edit Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154535&action=edit Bug 25393: UI adjustments This updates the information messages that are displayed in Staff, OPAC and SCO regarding renewals and if the item is up for automatic renewal or not. Add issues.auto_renew to svc/checkouts endpoint response -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154536&action=edit Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154537&action=edit Bug 25393: atomicupdate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154538&action=edit Bug 25393: Auto renewals logic reimplementation: Check if it's too soon for a manual renewal even if 'Automatic renewals' is enabled Allow for a manual renewal even if it's too soon for an automatic renewal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154539&action=edit Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154540&action=edit Bug 25393: Tests - Variable renaming issue_4 is an auto_renew issue, rename to auto_renew_issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154541&action=edit Bug 25393: Update Circulation.t prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22018 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154533|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154661&action=edit Bug 25393: Add new noautorenewalbefore circulation rule Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154534|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154662&action=edit Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154535|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154663&action=edit Bug 25393: UI adjustments This updates the information messages that are displayed in Staff, OPAC and SCO regarding renewals and if the item is up for automatic renewal or not. Add issues.auto_renew to svc/checkouts endpoint response Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154536|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154664&action=edit Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154537|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154665&action=edit Bug 25393: atomicupdate file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154538|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154666&action=edit Bug 25393: Auto renewals logic reimplementation: Check if it's too soon for a manual renewal even if 'Automatic renewals' is enabled Allow for a manual renewal even if it's too soon for an automatic renewal Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154539|0 |1 is obsolete| | --- Comment #18 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154667&action=edit Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154540|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154668&action=edit Bug 25393: Tests - Variable renaming issue_4 is an auto_renew issue, rename to auto_renew_issue Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154541|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 154669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154669&action=edit Bug 25393: Update Circulation.t prove t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This needs a rebase on top of bug 30362. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154661|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155307&action=edit Bug 25393: Add new noautorenewalbefore circulation rule Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154662|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155308&action=edit Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154663|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155309&action=edit Bug 25393: UI adjustments This updates the information messages that are displayed in Staff, OPAC and SCO regarding renewals and if the item is up for automatic renewal or not. Add issues.auto_renew to svc/checkouts endpoint response Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154664|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155310&action=edit Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154665|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155311&action=edit Bug 25393: atomicupdate file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154666|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155312&action=edit Bug 25393: Auto renewals logic reimplementation: Check if it's too soon for a manual renewal even if 'Automatic renewals' is enabled Allow for a manual renewal even if it's too soon for an automatic renewal Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154667|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155313&action=edit Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154668|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155314&action=edit Bug 25393: Tests - Variable renaming issue_4 is an auto_renew issue, rename to auto_renew_issue Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154669|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155315&action=edit Bug 25393: Update Circulation.t prove t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155307|0 |1 is obsolete| | Attachment #155308|0 |1 is obsolete| | Attachment #155309|0 |1 is obsolete| | Attachment #155310|0 |1 is obsolete| | Attachment #155311|0 |1 is obsolete| | Attachment #155312|0 |1 is obsolete| | Attachment #155313|0 |1 is obsolete| | Attachment #155314|0 |1 is obsolete| | Attachment #155315|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156829&action=edit Bug 25393: Add new noautorenewalbefore circulation rule Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156830&action=edit Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156831&action=edit Bug 25393: UI adjustments This updates the information messages that are displayed in Staff, OPAC and SCO regarding renewals and if the item is up for automatic renewal or not. Add issues.auto_renew to svc/checkouts endpoint response Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156832&action=edit Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156833&action=edit Bug 25393: atomicupdate file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156834&action=edit Bug 25393: Auto renewals logic reimplementation: Check if it's too soon for a manual renewal even if 'Automatic renewals' is enabled Allow for a manual renewal even if it's too soon for an automatic renewal Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156835&action=edit Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156836&action=edit Bug 25393: Tests - Variable renaming issue_4 is an auto_renew issue, rename to auto_renew_issue Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156837&action=edit Bug 25393: Update Circulation.t prove t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156838&action=edit Bug 25393: (QA follow-up) Report 'too_soon' errors from cron This patchset made it possible for 'too_soon' to be returned instead of 'auto_too_soon' - we just need to take that into account in the error listing To test: 1 - Set circ rule to no renewal before 2, no auto renewal before 3 2 - Checkout 3 items with auto renew, due tomorrow, in 2 days, in 3 days 3 - perl misc/cronjobs/automatic_renewals.pl -v 4 - Confirm 1 can be renewed, 1 is too soon, 1 is auto too soon Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156839&action=edit Bug 25393: (QA follow-up) simplify auto_renew condition _CanBookBeAutoRenewed will only ever return 'auto_too_soon' not 'too_soon' so we can do a simple equality check Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156840&action=edit Bug 25393: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Test plan: C4/Circulation.pm: if($auto_renew =~ 'too_soon'){ $auto_renew is return from _CanBookBeAutoRenewed - will never be 'too_soon' Check messages on opac-user 1 - Checkout 3 items to a patron, set for auto renewal, make sure due dates are: Tomorrow 2 days from now 3 days from now 2 - Set 'norenewalbefore' rule for this patron's issues to be 2 3 - View patron in OPAC, renewal should be denied for all 3 items: Automatic renewal ( 5 of 5 renewals remaining ) 4 - View patron in SCO, renewal should be denied for all 3 items: This item has been scheduled for automatic renewal and cannot be renewed 5 - View patron in staff interface, renewal should be denied for all 3 items Scheduled for automatic renewal(5 of 5 renewals remaining) 6 - Apply patch, updatedatabase, restart_all 7 - View circ rules, confirm new column 'no automatic renew before' with value equal to 'no renewal before' 8 - View patron in OPAC, 1 item can be renewed (due tomorrow), other 2 have updated message: Renew ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal. No renewal before 10/11/2023 ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal. No renewal before 10/12/2023 ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal. 9 - View patron in SCO, 1 can be renewed, updated messages on others: This item cannot yet be renewed. <Check in item> This item is scheduled for automatic renewal This item cannot yet be renewed. <Check in item> This item is scheduled for automatic renewal <Renew item> This item is scheduled for automatic renewal 10 - View patron in staff interface, 1 item can be renewed, other 2 have updated message: No renewal before 10/12/2023(5 of 5 renewals remaining) No renewal before 10/11/2023(5 of 5 renewals remaining) <Checkbox>(5 of 5 renewals remaining) 11 - Update circ rule, set 'no renewal before' to 3 12 - Should now be able to renew items due tomorrow and 2 days ahead on all interfaces 13 - Update circ rule, set 'no renewal before' to 4 14 - Should now be able to renew all items on all interfaces 15 - Renew 1 item on each interface, confirm success 16 - Check in items, checkout as before 17 - Update circ rules, set 'no renewal before' to 1 18 - Items cannot be renewed on any interface 19 - perl misc/cronjobs/automatic_renewals.pl -v found 3 auto renewals examining item '973' to auto renew examining item '974' to auto renew Issue id: 226 for borrower: 21 and item: 974 would not be renewed. (auto_too_soon) examining item '975' to auto renew Issue id: 227 for borrower: 21 and item: 975 would not be renewed. (auto_too_soon) 20 - Update circ rules, set 'no automatic renewal before' to 3 21 - perl misc/cronjobs/automatic_renewals.pl -v getting auto renewals found 3 auto renewals examining item '973' to auto renew examining item '974' to auto renew examining item '975' to auto renew Issue id: 227 for borrower: 21 and item: 975 would not be renewed. (auto_too_soon) 22 - Update circ rules, set 'no automatic renewal before' to 4 23 - perl misc/cronjobs/automatic_renewals.pl -v getting auto renewals found 3 auto renewals examining item '973' to auto renew examining item '974' to auto renew examining item '975' to auto renew 24 - Update circ rules, set 'no automatic renewal before' to 3 25 - perl misc/cronjobs/automatic_renewals.pl -v -c examining item '973' to auto renew examining item '974' to auto renew examining item '975' to auto renew Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon) 26 - Nothing is renewed, because 'no renewal before' is 1, too_soon for all 3 27 - Update circ rules, set 'no renewal before' to 2 28 - perl misc/cronjobs/automatic_renewals.pl -v -c getting auto renewals found 3 auto renewals examining item '973' to auto renew Issue id: 228 for borrower: 21 and item: 973 will be renewed. examining item '974' to auto renew examining item '975' to auto renew Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon) 29 - Confirm 1 issue was renewed 30 - Update circ rules, set 'no renewal before' to 3 31 - perl misc/cronjobs/automatic_renewals.pl -v -c getting auto renewals found 3 auto renewals examining item '973' to auto renew Issue id: 228 for borrower: 21 and item: 973 will not be renewed. (auto_too_soon) examining item '974' to auto renew Issue id: 229 for borrower: 21 and item: 974 will be renewed. examining item '975' to auto renew Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon) 32 - Confirm a second issue was renewed 33 - Update circ rules, set both ...renew before to 4 34 - Confirm third issue was renewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |This new circulation rule release notes| |allows libraries to control | |the no renewal before | |behaviour at the auto and | |non-auto renewals level. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 22018 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 35735 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 [Bug 36021] "Scheduled for automatic renewal" text displays even when not renewable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/917 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org