[Bug 16746] New: Can not find duplicated authorities cataloguing a new one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Bug ID: 16746 Summary: Can not find duplicated authorities cataloguing a new one Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: juan.sieira@xercode.es QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Can not find duplicated authorities cataloguing a new one, due to the new version of SimpleSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |juan.sieira@xercode.es Status|NEW |Needs Signoff --- Comment #1 from Juan Romay Sieira <juan.sieira@xercode.es> --- Created attachment 52440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52440&action=edit Patch to solve this issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 --- Comment #2 from Juan Romay Sieira <juan.sieira@xercode.es> --- 1. Add a new authority that exists in your authority server, Koha will now find none. 2. Apply the patch 3. Add a new authority that exists in your authority server, Koha will find similar authorities in your catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan.sieira@xercode.es -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 52440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52440 Patch to solve this issue Review of attachment 52440: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16746&attachment=52440) ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ +829,4 @@
} } my $searcher = Koha::SearchEngine::Search->new({index => $Koha::SearchEngine::AUTHORITIES_INDEX}); + my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1, [ "authorityserver" ]);
I don't think this is the correct solution, as ElasticSearch and Zebra both implement simple_search_compat, but ElasticSearch does not take the fourth parameter. Instead, it uses the objects 'index' accessor, which the Zebra version seems to be missing. Counter patch to follow today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16809 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I have something which does this problem, but there seems to be a larger issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 52869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52869&action=edit Bug 16746: Proposed start of counter-patch This is the beginning of a counter patch. Feel free to apply it and test it, Juan Romay Sieira. However, please expand the test plan to be more detailed: -- type X into field Y -- click button Z -- click downdrop W -- select item V -- enter 'text' into text box labelled A "Add a new authority that exists in your authority server, Koha will now find none." is not detailed enough for a person unfamiliar with the interface. Feel free to apply 16809 first. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52869|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 52870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52870&action=edit Bug 16746: Proposed start of counter-patch This is the beginning of a counter patch. Feel free to apply it and test it, Juan Romay Sieira. However, please expand the test plan to be more detailed: -- type X into field Y -- click button Z -- click downdrop W -- select item V -- enter 'text' into text box labelled A "Add a new authority that exists in your authority server, Koha will now find none." is not detailed enough for a person unfamiliar with the interface. Feel free to apply 16809 first. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16588 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to M. Tompsett from comment #6)
Created attachment 52870 [details] [review] Bug 16746: Proposed start of counter-patch
This is the beginning of a counter patch. Feel free to apply it and test it, Juan Romay Sieira. However, please expand the test plan to be more detailed:
-- type X into field Y -- click button Z -- click downdrop W -- select item V -- enter 'text' into text box labelled A
"Add a new authority that exists in your authority server, Koha will now find none." is not detailed enough for a person unfamiliar with the interface.
Feel free to apply 16809 first. :)
Are you going to continue on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 19415 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org