[Bug 13618] New: Prevent XSS everywhere at the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bug ID: 13618 Summary: Prevent XSS everywhere at the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13609, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13510, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13425, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11341, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13426 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Recently, we got a lot of security bugs related to potential XSS attack. We should think about a global solution instead of escaping everything manually in the templates. Any thoughs? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- http://www.perlmonks.org/?node_id=1059961 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35488&action=edit Bug 13618: [wip] Use Template::Stash::HTML::Entities to use the html filter Test plan: 0/ sudo cpanm Template::Stash::HTML::Entities 1/ Verify don't reproduce the XSS issue described on bug 13609. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35516&action=edit Revert "Bug 13609: Cross Site Scripting problem in authority search result list paging" This reverts commit c667b9ddbf42f9729d8f4035c7e872d5e980a5e9. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, is the second patch just for testing or supposed to go with this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, maybe we could think of resurrect some idea from bug 10075 and make it provide a escaped version of the params for direct usage? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Hi Jonathan, is the second patch just for testing or supposed to go with this?
It is part of the POC, all html filter will become useless in templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #6)
Jonathan, maybe we could think of resurrect some idea from bug 10075 and make it provide a escaped version of the params for direct usage?
I believe the solution I proposed is easier to implement, don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Interesting, I think its a good idea. One should consider the use do vars in JS code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Chris has found Template::Stash::AutoEscape: http://search.cpan.org/~mala/Template-Stash-AutoEscape-0.03/lib/Template/Sta... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- and more active: Template::Stash::AutoEscaping http://search.cpan.org/~shlomif/Template-Stash-AutoEscaping-0.0303/lib/Templ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Perhaps we could use this module http://search.cpan.org/~shlomif/Template-Stash-AutoEscaping-0.0303/lib/Templ... As it lets us do value.raw if we need unescaped values. But either we use it, or the HTML::Entities one, I think we should push it very soon. And we should do it on both the staff and opac sides -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Chris Cormack from comment #12)
Perhaps we could use this module
http://search.cpan.org/~shlomif/Template-Stash-AutoEscaping-0.0303/lib/ Template/Stash/AutoEscaping.pm
As it lets us do value.raw if we need unescaped values.
But either we use it, or the HTML::Entities one, I think we should push it very soon. And we should do it on both the staff and opac sides
+1 for Template::Stash::AutoEscaping -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35488|0 |1 is obsolete| | Attachment #35516|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40480&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40481&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40482&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14412 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14416, 14418, 14423 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40483&action=edit Bug 13618: Remove html filters at the intranet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40484&action=edit Bug 13618: Specific places where we don't need to escape variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40485&action=edit Bug 13618: Specific for pagination_bar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40487&action=edit Bug 13618: Specific for the ISBD view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14435 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- html code are generated in C4::Reports::Guided::format_results but this subroutine will be removed by bug 14435. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #22 from David Cook <dcook@prosentient.com.au> --- Neato burrito! This could come in really really handy... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Summary|Prevent XSS everywhere at |Prevent XSS in the Staff |the OPAC |Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Jonathan: Is this ready for testing now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #23)
Jonathan: Is this ready for testing now?
yep :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Would be great to get this tested, it will save us working on never ending individual fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry, could you please rebase. There are several files in conflict right now. I'll give this priority this week, so I'll try to test this ASAP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40480|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41346&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40481|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41347&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40482|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41348&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40483|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41349&action=edit Bug 13618: Remove html filters at the intranet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40484|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41350&action=edit Bug 13618: Specific places where we don't need to escape variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40485|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41351&action=edit Bug 13618: Specific for pagination_bar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40487|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41352&action=edit Bug 13618: Specific for the ISBD view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does not work: circulation.pl: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 618. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41353&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found something else, the checkout table is broken on circulation.pl (JS errors). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41354&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41355&action=edit Bug 13618: Specific for ColumnsSettings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #39 from Liz Rea <liz@catalyst.net.nz> --- This patch seems to break sysprefs such as intranetnav and opacmainuserblock - they show their HTML instead of interpreting it. I haven't checked all of the user configurable areas with this patch but we definitely should check them all. Off the top of my head (ok, ok, I went and looked through, but I still might have missed some): opacmainuserblock opacnav opacnavright opaccredits opacheader opacuserjs opacusercss opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs intranetusercss intranetuserjs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #40 from Liz Rea <liz@catalyst.net.nz> --- Ok, sorry I didn't have the last couple of patches - that's my bad but we still should check all of those sysprefs as part of testing. :) --- Comment #41 from Liz Rea <liz@catalyst.net.nz> --- Ok, sorry I didn't have the last couple of patches - that's my bad but we still should check all of those sysprefs as part of testing. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #42 from Liz Rea <liz@catalyst.net.nz> --- Actually, I'm sure I have all of the patches now, and intranetNav, at least, still has a problem. Also the news items are displaying their HTML, and they shouldn't be. LR -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #43 from Heather Braum <hbraum@nekls.org> --- If it's any sys pref that deals with HTML/JS/CSS, here's a few more to check; what about all the notices/slips templates? Do those need to be checked, too, since they also use HTML/JS/CSS? Extra user-edited sys prefs: OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #44 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 41746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41746&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #45 from Liz Rea <liz@catalyst.net.nz> --- On memberentrygen.tt, all of the cases for *popup are broken, they show the html we're sending in that variable instead of the dropdown. Most of them are conditional, the main reason I noticed was because of the Patron title: field. Suspect there will be heaps of stuff like this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #46 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 41747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41747&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41776&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for the pref list! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See https://github.com/joubu/Koha/tree/bug_13618 for an up-to-date patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42009&action=edit Bug 13618: Specific for Salutation on editing a patron -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41346|0 |1 is obsolete| | --- Comment #51 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42054&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #52 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Joonas Kylmälä from comment #51)
Created attachment 42054 [details] [review] Bug 13618: Use Template::Stash::AutoEscaping to use the html filter
Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability.
Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Thought it worked, but now noticed it broked the html in /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column it only shows html as plain text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41776|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42072&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42073&action=edit Bug 13618: Specific for XSLTBloc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #52)
(In reply to Joonas Kylmälä from comment #51)
Created attachment 42054 [details] [review] [review] Bug 13618: Use Template::Stash::AutoEscaping to use the html filter
Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability.
Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Thought it worked, but now noticed it broked the html in /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column it only shows html as plain text.
"Bug 13618: Specific for other prefs" reuploaded, OPACMySummaryNote was not correctly managed. New patch "Specific for XSLTBloc" should fix your issue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42073|0 |1 is obsolete| | --- Comment #56 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42075&action=edit Bug 13618: Specific for XSLTBloc Fixes the raw text nicely Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41350|0 |1 is obsolete| | --- Comment #57 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42078&action=edit Fixed the plain texts. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42078|Fixed the plain texts. |Bug 13618: Specific places description| |where we don't need to | |escape | | variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42079&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42079|0 |1 is obsolete| | --- Comment #59 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42087&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42072|0 |1 is obsolete| | --- Comment #60 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42090&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42009|0 |1 is obsolete| | --- Comment #61 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42091&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41352|0 |1 is obsolete| | --- Comment #62 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42092&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #63 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Jonathan Druart from comment #35)
Created attachment 41353 [details] [review] Bug 13618: Fix error 'Not a GLOB reference'
The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619.
The easier fix is to replace it with a SWITCH.
Did you considered adding .raw in the end of the Koha.Preference( 'AddressFormat' ) ? It would be more generalized code and it works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41351|0 |1 is obsolete| | --- Comment #64 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42093&action=edit Bug 13618: Specific for pagination_bar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41348|0 |1 is obsolete| | --- Comment #65 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42094&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41355|0 |1 is obsolete| | --- Comment #66 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42095&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42093|0 |1 is obsolete| | --- Comment #67 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42096&action=edit Bug 13618: Specific for pagination_bar Last time for some reason I didn't sign-off this even though I supposed to. Patch looks good. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #68 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Jonathan Druart from comment #28)
Created attachment 41347 [details] [review] Bug 13618: Remove html filters at the OPAC
This patch removes the html filters at the OPAC, if necessary.
Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc
@@ -85,7 +85,7 @@ [% END %] ). [% END %] - <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss |html %]&sort_by=acqdate_dsc&forma~ + <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~ [% END # / IF total %] </p> [% END # / IF searchdesc %] Shouldn't that one also be removed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #69 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Joonas Kylmälä from comment #68)
(In reply to Jonathan Druart from comment #28)
Created attachment 41347 [details] [review] [review] Bug 13618: Remove html filters at the OPAC
This patch removes the html filters at the OPAC, if necessary.
Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc
@@ -85,7 +85,7 @@ [% END %] ). [% END %] - <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss |html %]&sort_by=acqdate_dsc&forma~ + <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~ [% END # / IF total %] </p> [% END # / IF searchdesc %]
Shouldn't that one also be removed?
Also in this patch there was two more of these so they should be maybe removed also if this one is. I used regex ^\+.+\|html to find these -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41349|0 |1 is obsolete| | --- Comment #70 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 42097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42097&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #71 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Jonathan Druart from comment #37)
Created attachment 41354 [details] [review] Bug 13618: Specific for IntranetUser* and OPACUser* prefs
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -8,7 +8,7 @@ <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/bootstrap/css/bootstrap.min.css" /> <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/jquery/jquery-ui.css" /> <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/sco.css" /> -[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS %]</style>[% END %] +[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS.raw %]</style>[% END %] [% IF ( SCOUserCSS ) %]<style type="text/css">[% SCOUserCSS %]</style>[% END %] Why not have also raw SCOUserCSS if we let the user have OPACUserCSS as raw? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #72 from Joonas Kylmälä <j.kylmala@gmail.com> --- The front page in Staff side doesn't render html under News->What's Next. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #68)
(In reply to Jonathan Druart from comment #28)
Created attachment 41347 [details] [review] [review] Bug 13618: Remove html filters at the OPAC
This patch removes the html filters at the OPAC, if necessary.
Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc
@@ -85,7 +85,7 @@ [% END %] ). [% END %] - <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss |html %]&sort_by=acqdate_dsc&forma~ + <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~ [% END # / IF total %] </p> [% END # / IF searchdesc %]
Shouldn't that one also be removed?
I don't think so, I think I have tested them. (In reply to Joonas Kylmälä from comment #71)
Why not have also raw SCOUserCSS if we let the user have OPACUserCSS as raw?
Done in another patch. (In reply to Joonas Kylmälä from comment #72)
The front page in Staff side doesn't render html under News->What's Next.
New patch pushed to the remote branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #74 from Joonas Kylmälä <j.kylmala@gmail.com> --- Jonathan, The commits in GitHub branch look good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #74)
Jonathan, The commits in GitHub branch look good.
I have added you signed-off-by line on the 2 last patch. Feel free to mark the bug report as Signed off if you feel confident enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 [Bug 14744] Cannot select guarantor when quote in one of the fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #77 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #76)
Remote branch rebased.
Needs a new rebase, there are some conflicts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #79 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Jonathan, all patches apply, last patch signeed. I have a followup to remove some tabs/spaces Do I have to upload all here? Also found some "| html | html_line_break " and "| html | url " Don't know if they need to be removed git grep "|html " koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt:20: "[% data.borrowernotes.replace('\\\\' , '\\\\') |html |html_line_break |collapse %]", koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt:29: "[% data.borrowernotes.replace('\\\\' , '\\\\') |html |html_line_break |collapse %]", koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:44: No results found for that in [% LibraryName %] catalog. <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi | html | url %]&format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" border="0" class="rsssearchicon"/></a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt:88: <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" class="rsssearchicon"/></a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt:71: <td><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi |html |url %][% limit_cgi |html | url %]&[% s.query_cgi %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2" class="rsssearchlink"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" class="rsssearchicon"/></a> <a href="/cgi-bin/koha/opac-search.pl?[% s.query_cgi %]">[% s.query_desc %]</a></td> git grep "| html " koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:111: <td><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi |html |url %][% limit_cgi |html | url %]&[% s.query_cgi %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2" class="rsssearchlink"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" class="rsssearchicon"/></a> <a href="/cgi-bin/koha/opac-search.pl?[% s.query_cgi %]">[% s.query_desc %]</a></td> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #79)
Hi Jonathan, all patches apply, last patch signeed. I have a followup to remove some tabs/spaces
Where?
Do I have to upload all here?
No, I will add your signoffs on my branch.
Also found some "| html | html_line_break " and "| html | url " Don't know if they need to be removed
I don't think they should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #81 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45141&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #82 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #80)
(In reply to Bernardo Gonzalez Kriegel from comment #79)
Hi Jonathan, all patches apply, last patch signeed. I have a followup to remove some tabs/spaces
Where?
I attached a patch with fixes needed by koha-qa -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #82)
(In reply to Jonathan Druart from comment #80)
(In reply to Bernardo Gonzalez Kriegel from comment #79)
Hi Jonathan, all patches apply, last patch signeed. I have a followup to remove some tabs/spaces
Where?
I attached a patch with fixes needed by koha-qa
Thanks, added to the remote branch. Feel free to switch the status to Signed Off :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #84 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Checked opac and staff pages (not all), no problems found -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #85 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Mmm, some problems editing records and items There is a strange display on edit/add On items it can be fixed with something like --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -225,9 +225,9 @@ function confirm_deletion() { [% FOREACH ite IN item %] <li><div class="subfield_line" style="[% ite.visibility %]" id="subfield[% ite.tag %][% ite.subfield %][% ite [% IF ( ite.mandatory ) %] - <label class="required">[% ite.subfield %] - [% ite.marc_lib %]</label> + <label class="required">[% ite.subfield %] - [% ite.marc_lib.raw %]</label> [% ELSE %] - <label>[% ite.subfield %] - [% ite.marc_lib %]</label> + <label>[% ite.subfield %] - [% ite.marc_lib.raw %]</label> [% END %] [% SET mv = ite.marc_value %] @@ -258,7 +258,7 @@ function confirm_deletion() { [% ELSE %] <a href="#" id="buttonDot_[%- mv.id -%]" class="[%- mv.class -%]" title="Tag editor">...</a> [% END %] - [%- mv.javascript -%] + [%- mv.javascript.raw -%] [% ELSIF ( mv.type == 'text' ) %] <input type="text" id="[%- mv.id -%]" name="field_value" class="input_marceditor" size="50" maxlength="[ [% ELSIF ( mv.type == 'textarea' ) %] But there are some javascript errors in the console. And we need a fix for record editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Good catch Bernardo. Fixed. commit de101ae8b8e04eeb04abe83cbb69cc02bfa87eff Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please guys, we need a quick push of this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #88 from Marc Véron <veron@veron.ch> --- Wanted to test, got: Applying: Bug 13618: Remove html filters at the OPAC fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #89 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please use the remote branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/joubu/Ko | |ha/tree/bug_13618 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #90 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #89)
Please use the remote branch.
Hi, there is a easy conflict on koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc :) Record and item editor now look good, but on item editor there is a 'Uncought SyntaxError: Unxepected token &', seems to come from var columns_settings = [{"columnname":"barcode"}, {"columnname":"dateaccessioned"}, ... {"columnname":"stocknumber"}] No errors on record editor or plugins, there is a warning on MARC 006/008 "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #90)
(In reply to Jonathan Druart from comment #89)
Please use the remote branch.
Hi, there is a easy conflict on koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc :)
Rebased.
Record and item editor now look good, but on item editor there is a 'Uncought SyntaxError: Unxepected token &', seems to come from
var columns_settings = [{"columnname":"barcode"}, {"columnname":"dateaccessioned"}, ... {"columnname":"stocknumber"}]
Introduced by a new patch, fixed in a new commit "Bug 13618: (follow-up) Specific for ColumnsSettings"
No errors on record editor or plugins, there is a warning on MARC 006/008 "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/."
Could you confirm you don't have it on master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #92 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #91)
Rebased.
Ok!
Introduced by a new patch, fixed in a new commit "Bug 13618: (follow-up) Specific for ColumnsSettings"
No more error
Could you confirm you don't have it on master?
It's on master, no a problem of this patchset. No koha-qa errors. Changed to Signed-Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #92)
(In reply to Jonathan Druart from comment #91) Changed to Signed-Off
Thanks Bernardo! I have added your signed-off-by line to the last 2 patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #94 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 45784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45784&action=edit Screenshot opac-shelves.pl on /cgi-bin/koha/opac-shelves.pl the page returned's styling/layout goes funny with this patch set. Please see attached screenshot. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #95 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 45785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45785&action=edit List pages in OPAC also broken when the list contains items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #96 from Liz Rea <liz@catalyst.net.nz> --- Actually, please look over the lists functions in the OPAC generally, as they really seem worse for the wear after this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #97 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45788&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #98 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Liz Rea from comment #96)
Actually, please look over the lists functions in the OPAC generally, as they really seem worse for the wear after this patch.
Could you test with last patch on top? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #99 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #98)
(In reply to Liz Rea from comment #96)
Actually, please look over the lists functions in the OPAC generally, as they really seem worse for the wear after this patch.
Could you test with last patch on top?
Thanks Bernardo, it fixes the issue. I have signed off the patch and pushed it to the branch. It comes from a merge conflict (on Bug 13618: Remove html filters at the OPAC) which I have not fixed correctly in one of the many rebases. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Branches rebased against master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #101 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Branch rebased against master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, as promised, started testing this. I checked out your branch, without rebasing it to current master. I had to install 2 dependencies via cpanm: sudo cpanm Template::Stash::HTML::Entities sudo cpanm Template::Stash::AutoEscaping We need to make sure those can be packaged! Some glitches I found: Prio 1: - HTML printer slips are broken To test: Patron account > print quick slip Others: - Patron account in staff > notices tab > HTML notices To test: use an HTML version of a check-in or check-out notice - System preferences containing HTML tags display them To test: search for 'note' in system preferences - Staff > detail page > MARC view > Items tab > displays in URL column To test: Add a 952$u to one of multiple items Some I am not totally sure about, but there is a change in behaviour to before: - HTML tags in restriction/debarment comments - HTML tags in messages in the patron account ('new message' link) Stopping my testing for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #103 from Galen Charlton <gmcharlt@gmail.com> --- Not seeing any immediate bar to attempting to package the new deps, but I should emphasize that new dependencies means that this is not backportable as far as the packages are concerned. To emphasize this point, I've recategorized this bug as an enhancement, as it's more about implementing a global solution rather than fixing a bunch of individual XSS issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #104 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #102) Everything has been fixed in the following new commits: commit 13faef4d28df0a70c2c89ab4317ebc2882fc3704 Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them commit 2879a9976549f84c9520d5778a45d8348845d7b4 Bug 13618: Do not display and html tags in item fields content Note that there might be other occurrences to fix! commit d8547698a47e83cdb7d321391cadddd4f26e5f85 Bug 13618: Do not display html tags in patron's notices commit 58e62b53eda1110003d6c0b0cebc983c62bf2f46 Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. commit 0aefdddb394db1fab7287970ab0b80f3a92479e8 Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS Remote branch updated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, feel free to ask to new signoffs on these patches if you think it's needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #106 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I (re)testd some more: NOW OK: - Patron account in staff > notices tab > HTML notices - System preferences containing HTML tags display them To test: search for 'note' in system preferences - Staff > detail page > MARC view > Items tab > displays in URL column To test: Add a 952$u to one of multiple items - HTML tags in messages in the patron account ('new message' link) NOT OK: - HTML printer slips are broken To test: Patron account > print quick slip This shows still the same problem for and I don't see a patch with a matching description on the branch? - HTML tags in restriction/debarment comments Works partially - the restriction message on top of the patron account is ok. The entries in the little restrictions table inside the tab still appear broken - on the details and checkout tabs and also when editing a patron. Other test results: - OPAC is looking good, nothing found - Staff is looking good as well - no new findings. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One more thing - I had to install 2 dependencies to get it to work. - Should both go into the PerlDependencies.pm file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #108 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last 2 patches updated on the remote branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #102)
I had to install 2 dependencies via cpanm: sudo cpanm Template::Stash::HTML::Entities sudo cpanm Template::Stash::AutoEscaping
Are you sure about that? I have removed Template::Stash::HTML::Entities and everything looks fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But comment#3 told me to install it! Maybe it's not needed then :) I can retest this as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #111 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, working on this again - can you please update your branch to master once more? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #112 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Retesting the issues found last time: - HTML printer slips work perfectly now - HTML tags in restriction/debarment comments show ... and while you are on it, could you please add my sign off lines as well? :) I am going to obsolete the patches here for now, to avoid confusion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Works partially - the restriction message on top of the patron account is ok. The entries in the little restrictions table inside the tab still appear broken - on the details and checkout tabs and also when editing a patron.variables - intra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42087|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42078|Bug 13618: Specific places |Bug 13618: Specific places description|where we don't need to |where we don't need to |escape |escape | variables - intra | variables - intra Attachment #42078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45788|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #114 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46767&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #115 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46768&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #116 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46769&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46770&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46771&action=edit Bug 13618: Specific places where we don't need to escape variables - intra Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46772&action=edit Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46773&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46774&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #122 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46775&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46776&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #124 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46777&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46778&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #126 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46779&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46780&action=edit Bug 13618: Specific for XSLTBloc Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #128 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46781&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46782&action=edit Bug 13618: Fix for news Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #130 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46783&action=edit Bug 13618: Fix last occurrences recently introduced to master Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #131 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46784&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #132 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46785&action=edit Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46786&action=edit Bug 13618: (follow-up) Specific for ColumnsSettings Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46787&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #135 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46788&action=edit Bug 13618: Remove html filters for newly pushed code Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #136 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46789&action=edit Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #137 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46790&action=edit Bug 13618: Do not display and html tags in item fields content Note that there might be other occurrences to fix! Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #138 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46791&action=edit Bug 13618: Do not display html tags in patron's notices Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #139 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46792&action=edit Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #140 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46793&action=edit Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS and printslip Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #141 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46794&action=edit Bug 13618: Specific for branches.opac_info -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #142 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #112)
Retesting the issues found last time: - HTML printer slips work perfectly now - HTML tags in restriction/debarment comments show
... and while you are on it, could you please add my sign off lines as well? :)
I am going to obsolete the patches here for now, to avoid confusion.
I have added your signed-off-by line, attached the patches from the remote branch on this bug report and attached a new patch (found a bug when rebasing). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46767|0 |1 is obsolete| | --- Comment #143 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46795&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46768|0 |1 is obsolete| | --- Comment #144 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46796&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46769|0 |1 is obsolete| | --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46797&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46770|0 |1 is obsolete| | --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46798&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46771|0 |1 is obsolete| | --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46799&action=edit Bug 13618: Specific places where we don't need to escape variables - intra Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46772|0 |1 is obsolete| | --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46800&action=edit Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46773|0 |1 is obsolete| | --- Comment #149 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46801&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46774|0 |1 is obsolete| | --- Comment #150 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46802&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46775|0 |1 is obsolete| | --- Comment #151 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46803&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46776|0 |1 is obsolete| | --- Comment #152 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46804&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46777|0 |1 is obsolete| | --- Comment #153 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46805&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46778|0 |1 is obsolete| | --- Comment #154 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46806&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46779|0 |1 is obsolete| | --- Comment #155 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46807&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46780|0 |1 is obsolete| | --- Comment #156 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46808&action=edit Bug 13618: Specific for XSLTBloc Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46781|0 |1 is obsolete| | --- Comment #157 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46809&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46782|0 |1 is obsolete| | --- Comment #158 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46810&action=edit Bug 13618: Fix for news Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46783|0 |1 is obsolete| | --- Comment #159 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46811&action=edit Bug 13618: Fix last occurrences recently introduced to master Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46784|0 |1 is obsolete| | --- Comment #160 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46812&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46785|0 |1 is obsolete| | --- Comment #161 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46813&action=edit Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46786|0 |1 is obsolete| | --- Comment #162 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46814&action=edit Bug 13618: (follow-up) Specific for ColumnsSettings Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46787|0 |1 is obsolete| | --- Comment #163 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46815&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46788|0 |1 is obsolete| | --- Comment #164 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46816&action=edit Bug 13618: Remove html filters for newly pushed code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46789|0 |1 is obsolete| | --- Comment #165 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46817&action=edit Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46790|0 |1 is obsolete| | --- Comment #166 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46818&action=edit Bug 13618: Do not display and html tags in item fields content Note that there might be other occurrences to fix! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46791|0 |1 is obsolete| | --- Comment #167 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46819&action=edit Bug 13618: Do not display html tags in patron's notices Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46792|0 |1 is obsolete| | --- Comment #168 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46820&action=edit Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46793|0 |1 is obsolete| | --- Comment #169 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46821&action=edit Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS and printslip Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46794|0 |1 is obsolete| | --- Comment #170 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46822&action=edit Bug 13618: Specific for branches.opac_info -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org