[Bug 40565] New: Column filters on the item search do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Bug ID: 40565 Summary: Column filters on the item search do not work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184924&action=edit Bug 40565: Fix column filters on item search The item search table is different from the other tables. It is using server-side but its own way (not using the REST API). Test plan: Search items and filter using the column filters: collections, library, item types, AVs, etc. QA: I am not very happy with this patch but, feel free to suggest a better fix! Note that "results" was too generic and it felt better to adjust it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38311 [Bug 38311] DataTables - Simplify the building of the dropdown list filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184924|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 184973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184973&action=edit Bug 40565: Fix column filters on item search The item search table is different from the other tables. It is using server-side but its own way (not using the REST API). Test plan: Search items and filter using the column filters: collections, library, item types, AVs, etc. QA: I am not very happy with this patch but, feel free to suggest a better fix! Note that "results" was too generic and it felt better to adjust it. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184973|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186744&action=edit Bug 40565: Fix column filters on item search The item search table is different from the other tables. It is using server-side but its own way (not using the REST API). Test plan: Search items and filter using the column filters: collections, library, item types, AVs, etc. QA: I am not very happy with this patch but, feel free to suggest a better fix! Note that "results" was too generic and it felt better to adjust it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described. Since item search doesn't use the API and has its own way of handling parameters it makes sense that the values of the options in the table header dropdowns need to be the plain codes instead of a regex for starting and ending with the code. Changing the id of the table to item_search to be more specific makes this change to datatables.js more clear. I like how simple this solution is, and couldn't come up with any alternative. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Text to go in the| |This patch fixes a problem release notes| |that made the column search | |filters not to work when | |doing an item search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This is causing a problem with the datatable on http://localhost:8081/cgi-bin/koha/acquisition/vendors: Uncaught (in promise) TypeError: table_node.attr is not a function I think it's maybe responsible for the failures I see here also: https://jenkins.koha-community.org/job/Koha_Main/lastCompletedBuild/testRepo... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186903&action=edit Bug 40565: (follow-up) Make sure there is a table_node -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |ASSIGNED --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I am working a follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186911&action=edit Revert "Bug 40565: (follow-up) Make sure there is a table_node" This reverts commit addd5e3a0d32e227834c02c2b16ac735decb80fa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186912&action=edit Bug 40565: Correctly fix the retrieval of 'id' For other tables than those from Vue apps, table_node is the node and we need to retrieve the object before accessing the attr function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA Depends on| |40876 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Found a separate bug that was linked to the last failure. It needs to be pushed before the last 2 patches. Lucas: please push the patch from bug 40876 then: Revert "Bug 40565: (follow-up) Make sure there is a table_node" Bug 40565: Correctly fix the retrieval of 'id' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40876 [Bug 40876] DT - Exact search not applied on second attribute for column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- After this you should run prove t/db_dependent/selenium/patrons_search.t cypress run --spec t/cypress/integration/ERM/Licenses_spec.ts cypress run --spec t/cypress/integration/KohaTable/PatronSearch_spec.ts They must all pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-ups here pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11)
Found a separate bug that was linked to the last failure.
It needs to be pushed before the last 2 patches.
Lucas: please push the patch from bug 40876 then: Revert "Bug 40565: (follow-up) Make sure there is a table_node" Bug 40565: Correctly fix the retrieval of 'id'
I have pushed in this order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.11 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org