[Bug 27629] New: Filter invoices by library in invoices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Bug ID: 27629 Summary: Filter invoices by library in invoices.pl Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dch@interleaf.ie QA Contact: testopia@bugs.koha-community.org Filter invoices by library doesn't work in invoices.pl Some invoices will be listed but not all the applicable invoices. An easy way to reproduce this problem is to list all the invoices within a date range, make a note of the invoices for one particular library, now filter your list by that library and you will notice that all the invoices you expect are listed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you confirm the invoices that are missing are linked with a basket that has the authorisedby column not NULL? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 --- Comment #2 from Daphne Hoolahan <dch@interleaf.ie> --- The missing invoices are all linked to a basket. Baskets have authorisedby column = 0. What is the significance of authorisedby for this filter? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Status|NEW |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- When the "library" filter on the invoice page is set, a JOIN is done on the borrowers table using the branchcode of this patron. And aqbasket.authorisedby is the borrowernumber of the librarian who created the basket. BUT if the patron is removed, the column will be set to NULL, and the JOIN will not return the invoices created by this (now deleted) patron. There is a "Managing library" (aqbasket.branch) at basket level, maybe we should use it instead of borrowers.branchcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, the managing library was introduced later - which could explain why it was not used in the first place. In my experience libraries often forget to set it, but it would be more reliable in this case. Daphne, would it work for your data? The meaning of authorised_by in several places has led us to migrate with a migration acq user for a valid borrowernumber, which helps, but is not a real good solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 --- Comment #5 from Daphne Hoolahan <dch@interleaf.ie> --- Managing Library might be more straightforward but my problem is arising on baskets created from EDI Quotes or the GOBI API so either way we are going to be dependent on data supplied by the vendor or an update when the basket is created. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Clodagh Kerin <clodagh.kerin@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we maybe do both, a search option for managing library or a fallback on managing library for the search option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org