[Bug 8262] New: Could not add or create List in koha 3.8.1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Priority: P5 - low Change sponsored?: --- Bug ID: 8262 Assignee: gmcharlt@gmail.com Summary: Could not add or create List in koha 3.8.1 Severity: enhancement Classification: Unclassified OS: Linux Reporter: bondwal.amit@gmail.com Hardware: PC Status: NEW Version: rel_3_8 Component: Architecture, internals, and plumbing Product: Koha Hi Folks, I am new to koha, I installed koha 3.8.1 on centos 6.2 working fine, but when I tried to use List option on administration, It did not create List. When I tried to create a new List, It open popup window and ask for List Name and Select public and private etc., When I saved the List it shows nothing in Lists. Please help me. Thanks and regards Amit Bondwal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Amit, Could you please describe the exact steps to reproduce your problem. The more details you provide, the better help you may get. Are you using opac or staff client? Are you logged in? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 verolencinas <verolencinas@yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |verolencinas@yahoo.com.ar Resolution|--- |FIXED --- Comment #2 from verolencinas <verolencinas@yahoo.com.ar> --- The problem is solved if you create the list logged in as a normal user (not kohaadmin). If you try to create a list logged in as administrator, you don't have a borrowernumber and koha can't create lists who don't belong to a user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version|rel_3_8 |master Component|Architecture, internals, |Virtual Shelves |and plumbing | Hardware|PC |All Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Resolution|FIXED |--- Summary|Could not add or create |Special kohaadmin cannot |List in koha 3.8.1 |create lists Severity|enhancement |major OS|Linux |All --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I would like to reopen this report. verolencinas: What you say, is correct. But i would say that it is not a solution but a workaround. Koha should give a warning on screen here and not only produce a sql error in the logfile. I will submit a proposed patch soon to check the user and raise a warning in this situation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Marcel, Your patch would address Paul P.'s comment to following bug: Bug 8641 - Add information warning about log-in as root user to About->System information (Pushed to Master) See: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641#c4 Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8641 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25756&action=edit Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan: This patch should be applied on top of 9032 patches. Login as kohaadmin under opac and staff. Create a list in opac and staff. Check the message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25757&action=edit Bug 8262: Follow-up for bootstrap theme Provide a warning under bootstrap when kohaadmin tries to create a list. Test plan: Login as special kohaadmin. Create a list in OPAC with bootstrap theme. Check the message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9032 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have built this upon patches for bug 9032. Please wait testing this until I submitted these patches. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Existing warnings in the staff client use the term "database administrator account." I think this patch should use the same phrase, instead of "special administrator account." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Instead of having all this code in the perl scripts, wouldn't it be far simpler to to check C4::Context->userenv->{number} and display a warning that this account can't create a list? A TT plugin for userenv access could simplify this even more. I think a UserEnv sub that returned whatever $userenv->{$key} could easily be added to the Koha TT plugin. In addition, the code assumes that any failure should generate this message, which may not always be the case. I'd say that's a qa blocker. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #9)
Instead of having all this code in the perl scripts, wouldn't it be far simpler to to check C4::Context->userenv->{number} and display a warning that this account can't create a list?
A TT plugin for userenv access could simplify this even more. I think a UserEnv sub that returned whatever $userenv->{$key} could easily be added to the Koha TT plugin.
In addition, the code assumes that any failure should generate this message, which may not always be the case. I'd say that's a qa blocker.
All this code is only a few lines (the AddShelf line is an improvement in any case). But I would not oppose a warning in the template either. A better message would be fine. The actual warning is now: List could not be created (which is pretty generic :) Between brackets, a reminder Do not use kohaadmin (which will be in this case btw a frequent cause). No blockers for me. How do we get this further now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25756|0 |1 is obsolete| | Attachment #25757|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25971&action=edit Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- New patch includes the bootstrap change too now. Thanks Owen and Kyle for suggestions. Made the template varname generic and the error message dependent of loggedinuser. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25971|0 |1 is obsolete| | --- Comment #13 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 26066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26066&action=edit Attachment to Bug 8262 - Special kohaadmin cannot create lists [SIGNED-OFF] Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26066|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26526&action=edit [PASSED QA] Bug 8262: Special kohaadmin cannot create lists Since kohaadmin has no borrower number, it cannot create lists. A database error is logged, but the user is not notified. This patch alerts the user (kohaadmin). In the incidental case that a normal user gets a database error, he is notified too that the list could not be created. Test plan (for prog and bootstrap): This patch should be applied on top of 9032 patches. Login as kohaadmin. Create a list in opac and staff. Check the message. Login as a normal user. Force a database error on list creation (I renamed category in the table with alter table change column..) You should have a different error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org