[Bug 18446] New: Test to ensure a system preference in .pref file also exists in sysprefs.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Bug ID: 18446 Summary: Test to ensure a system preference in .pref file also exists in sysprefs.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: lari.taskula@jns.fi QA Contact: gmcharlt@gmail.com Extend t/db_dependent/check_sysprefs.t to read preferences from .pref files in order to check that they are also defined in installer/data/mysql/sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 62298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62298&action=edit Bug 18446: Compare preferences in .pref files to sysprefs.sql This patch adds a test that reads system preferences from .pref files and checks that they are also defined in sysprefs.sql. To test: 1. prove t/db_dependent/check_sysprefs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |lari.taskula@jns.fi Status|NEW |Needs Signoff --- Comment #2 from Lari Taskula <lari.taskula@jns.fi> --- This test caught the following preferences: ArticleRequestsMandatoryFieldsItemOnly, HoldsInNoissuesCharge, NoRenewalBeforePrecision, OPACPopupAuthorsSearch, OPACPrivacy, OPACSuggestionMandatoryFields, OpacGroupResults, ReplytoDefault, SelfCheckoutByLogin, TalkingTechItivaPhoneNotification, marcflavour Add them to sysprefs.sql to make this test pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18444 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There are a few exceptions like marcflavour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
There are a few exceptions like marcflavour
Should be filled by the user in the web installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think before this can go in, we need 2 things: - Exclude marcflavour as it is added and set by the web installer - Write a patch to add the missing preferences to syspref.sql and maybe also have an atomicupdate checking for their existence and adding when needed to get to a clean state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18513 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org