[Bug 14033] New: Capitalization: confirmation message on deleting an authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Bug ID: 14033 Summary: Capitalization: confirmation message on deleting an authority type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The capitalization on the confirmation message for deleting an authority type doesn't follow our rules. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Do you mean something like: Confirm deletion of authority structure definition for 'Uniform Title' (UNIF_TITLE) in cgi-bin/koha/admin/authtypes.pl?op=delete_confirm&authtypecode=UNIF_TITLE 'Uniform Title' comes from the description of this authority type. Or am I looking at the wrong place? :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Try and delete one - it says: No, Do Not Delete... which is not what our rules say :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #3 from Marc Véron <veron@veron.ch> --- git grep 'No, Do' koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 38303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38303&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Assignee|oleonard@myacpl.org |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38303|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38608&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, please also correct the 'Yes, Delete' and similar on those templates, so both messages match again. there are also some others, like: Delete this Currency (for yes). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38608|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 38633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38633&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> --- Amended to replace more strings, see comment #6 / mv -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38633|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38686&action=edit [PASSED QA] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed some tabs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org