https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869 Bug 7654: Add location at opac subscription view Review of attachment 58869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7654&attachment=58869) ----------------------------------------------------------------- Here are some untested thoughts. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +796,4 @@

<p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p> [% FOREACH subscription IN subscriptions %] [% IF ( subscription.branchcode ) %] + <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3>

What if it gets a branch, but someone failed to enter a description or it is blank? Displaying the branchcode in that case would make sense. I do not think this correction is correct. [% at_library = Branches.GetName( subscription.branchcode ) %] [% SET at_library = subscription.branchcode IF at_library.length=0 %] [% IF at_library %] <h3>At library: [% at_library ) %]</h3> [% END %] @@ -799,5 @@

- <h3>At library: [% Branches.GetName( subscription.branchname ) %]</h3> - [% ELSE %] - [% IF ( subscription.branchcode ) %] - <h3>At library: [% subscription.branchcode %]</h3> - [% END %]

I'm pretty sure this code was intending to display a branch name if possible, but if not just the branch code. And clearly, it is wrong about that. @@ +813,5 @@

<p>[% subscription.opacnote FILTER html_line_break %]</p> [% END %] + [% IF subscription.location_description || subscription.location %] + <p>Location: [% IF subscription.location_description %][% subscription.location_description %][% ELSE %][% subscription.location %][% END %]</p> + [% END %]

[% location_description = subscription.location_description %] [% SET location_description = subscription.location IF ! defined location_description || location_description.length=0 %] [% IF location_description %] <p>Location: [% location_description %]</p> [% END %] -- You are receiving this mail because: You are watching all bug changes.