[Bug 23483] New: When writing off a fine, the title of the patron is shown as description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Bug ID: 23483 Summary: When writing off a fine, the title of the patron is shown as description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When writing of an individual fine or fee, the description column shows the title of the patron (mr, mrs, borrowers.title). Could this be a variable confusion? (Record title vs. patron title?) So far confirmed in latest 18.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master now as well. To test: - Make sure that in the account you use a saluation is set (Mr Mrs...) - Create a manual fine - Pay or Writeoff the fine using the buttons next to the fine (not at the bottom) - Look at the description shown before saving -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #1)
Confirmed on master now as well.
To test: - Make sure that in the account you use a saluation is set (Mr Mrs...) - Create a manual fine - Pay or Writeoff the fine using the buttons next to the fine (not at the bottom) - Look at the description shown before saving
It only happens for writeoff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94986&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94986|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 94992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94992&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you Severine! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94992|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95116&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch works as expected.. passing qa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We found this in 18.11 - please backport! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley@catalyst.net.n | |z --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Lucas and Hayley :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00, 18.11.12 |19.11.00, 19.05.06, released in| |18.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org