[Bug 13410] New: Untranslatable "Change messaging preferences to default for this category?"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Bug ID: 13410 Summary: Untranslatable "Change messaging preferences to default for this category?" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr To reproduce: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Message box asks for confirmation ("Change messaging preferences to default for this category?") Do the same in an other language Result: Text appears in English. Reason: JavaScript message is not surrounded by _(...) in memberentrygen.tt line 1343 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 34245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34245&action=edit Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34245|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34276&action=edit [SIGNED-OFF] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34276|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34343&action=edit [PASSED QA] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34344&action=edit Bug 13410 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Contains string changes, holding for 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Version|master |3.16 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to Chris Cormack from comment #6)
Contains string changes, holding for 3.18.3
Contains string changes, holding for 3.18.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #8)
(In reply to Chris Cormack from comment #6)
Contains string changes, holding for 3.18.3
Contains string changes, holding for 3.18.8
oops ^ Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org