[Bug 10153] New: Patron header search form is too wide
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Bug ID: 10153 Summary: Patron header search form is too wide Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Created attachment 17807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17807&action=edit Screenshot showing the patron header search form layout problem The patron header search form (as seen for instance on members/members-home.pl) is too wide for browsers windows narrower than about 1110px. Some or all of the search options should be hidden by default in order to make the layout work better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17813&action=edit Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17813|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 17814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17814&action=edit [SIGNED-OFF] Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17814|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17823&action=edit [PASSED QA] Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works for me. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. I like this change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch seems to work fine, but there is something annoying about patron search. Student and library remember the value after sending the search - but Search fields, Search type and Order by revert to default. I will file a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- I think there is already another report for that issue - I think I reported it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org