https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29125 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 22316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 [Bug 30059] Add a JS equivalent to Koha::Patron->get_age -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130364&action=edit Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130366&action=edit Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130368&action=edit Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130370&action=edit Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29136 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130372&action=edit Bug 30055: Prevent blink when page is loading -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum, found something here. I removed the "patron_preview" thing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130364|0 |1 is obsolete| | Attachment #130365|0 |1 is obsolete| | Attachment #130366|0 |1 is obsolete| | Attachment #130367|0 |1 is obsolete| | Attachment #130368|0 |1 is obsolete| | Attachment #130369|0 |1 is obsolete| | Attachment #130370|0 |1 is obsolete| | Attachment #130371|0 |1 is obsolete| | Attachment #130372|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130385&action=edit Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130387&action=edit Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130389&action=edit Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130391&action=edit Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130393&action=edit Bug 30055: Prevent blink when page is loading -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130395&action=edit Bug 30055: Add missing include to format addresses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm on board too, great work Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great enhancement, more API \o/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, right now I'm getting 404's on the API requests in my testing.. continuing to investigate. Couple of comments to get us started though.. * It might be nice to enable `"header_filter": true,` on the kohaTable.. the URL's are pretty crazy to read without it. * Was it a deliberate choice to use 'add_filters'.. for the guarantor search at least, this is a change and I'm not sure it makes sense to have the both sets of filters visible at the same time in the popup window? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130487&action=edit Bug 30055: Add missing spec file for baskets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130491&action=edit Bug 30055: Missing search on othernames -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #29)

Hmm, right now I'm getting 404's on the API requests in my testing.. continuing to investigate.

Couple of comments to get us started though..

* It might be nice to enable `"header_filter": true,` on the kohaTable.. the URL's are pretty crazy to read without it.

Not strongly attached to that. Could switch to header_filter if your prefer.

* Was it a deliberate choice to use 'add_filters'.. for the guarantor search at least, this is a change and I'm not sure it makes sense to have the both sets of filters visible at the same time in the popup window?

Yes, that's definitely a deliberate choice. The idea is to keep the same filters as before on top of the table, but provide a way to refine the search with the column's filters. I would like to have the same behaviour/UI on all patrons search. You also noticed the "Browse by last name" that will be there as well. (In reply to Martin Renvoize from comment #30)

Also, could we get a little update for the jsdoc for kohaTable for the changes/enhancements you've made.. especially the signature update for default_filters?

Yep, I was waiting for the other bug follow-ups and feedbacks to make sure it's the correct way to accomplish that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 [Bug 30093] Rewrite some of the patron searches when placing a hold with the REST API route -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon@cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 [Bug 30093] Rewrite the patron search when placing a hold with the REST API route -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130630&action=edit Bug 30055: (follow-up) Clarify 'AND' logic -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #39)

When I test searches which are limited to staff users I get an error: "Embedding objects is not allowed on this endpoint."

Yes, it's the last patch that is causing problems. I am obsoleting it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130671&action=edit Bug 30055: (follow-up) Add missing embed in fund owners -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #40)

(In reply to Owen Leonard from comment #39)

...

When I test searches which are limited to staff users I get an error: "Embedding objects is not allowed on this endpoint."

Yes, it's the last patch that is causing problems. I am obsoleting it.

To clarify, this patch was not causing Owen's issue. However I found yesterday: https://snipboard.io/3eYNEw.jpg I am searching for "sss" which I know return 1 result (from extended attribute) then I filter general on "ed" => still one result => all good then: https://snipboard.io/HYJyuU.jpg I am adding "ed" to filter on surname It should NOT change anything in the result set, as "Edna" contains "ed" but it does not returning anything If I am continuing to play, I am getting a 500 at some point (don't know exactly from which point it happened) the 500 is: GET /api/v1/patrons: unhandled exception (DBIx::Class::Exception)<<SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Supplying an empty left hand side argument is not supported. in array-pairs at /usr/share/perl5/Data/Page.pm line 49>> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73)... So the query is badly construct. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #44)

I can't replicate these issues

Well, it's very easy to recreate. Create a new fresh ktd or use a sandbox, then add a guarantor: https://snipboard.io/bAUyDn.jpg remove "ed" from "Name" => you get "edna" Adding "ed" in Name should NOT remove Edna from the result list! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #45)

(In reply to Martin Renvoize from comment #44)

...

I can't replicate these issues

Well, it's very easy to recreate. Create a new fresh ktd or use a sandbox, then add a guarantor: https://snipboard.io/bAUyDn.jpg

remove "ed" from "Name" => you get "edna" Adding "ed" in Name should NOT remove Edna from the result list!

tl;dr; version of the discussion on the chat: the version *without* Martin's patch has this bug as well... Yesterday the test I made was with search a pattern matching an extended attribute in the "main search", but that is not working either. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130672|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130701&action=edit Bug 30055: (follow-up) Add missing embeds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #47)

When limiting search via the table filters, dropdowns should be filtered on equality, not contains.

To recreate: search for '%' in the search to return all patrons use category dropdown to limit to 'Patron' - works use category dropdown to limit to 'Teacher' - fail - you see 'Patron' and 'Student' categories because they contain 'T' - the code for 'Teacher'

Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130704&action=edit Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130716|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130717&action=edit Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Bug 30055 depends on bug 30060, which changed state. Bug 30060 Summary: Missing primary key on user_permissions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #55)

(In reply to Jonathan Druart from comment #51)

...

(In reply to Jonathan Druart from comment #49)

...

Created attachment 130702 [details] [review] [review] [review] Bug 30055: Force exact match for dropdown

For libraries and categories we need to use an exact match.

This patch is a bit awkward, feel free to suggest a better alternative if you found one!

What you really want is bug 29302, don't you?

I don't think so. Here we are syncing the form with the DT filters when the form is submitted. We are not initializing the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132168&action=edit Bug 30055: clear the column filter if none selected ie. search for "", not "^$" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Bug 30055 depends on bug 30059, which changed state. Bug 30059 Summary: Add a JS equivalent to Koha::Patron->get_age https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #59)

Ok, I tested again, in the suggestions page: - When you choose your own user, it is described as 'null koha' instead of the original 'You' that is displayed when you enter the page.

This is already the case in master, nevermind. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30393 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130386|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132419&action=edit Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132421&action=edit Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132423&action=edit Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #67 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132425&action=edit Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #69 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132427&action=edit Bug 30055: Prevent blink when page is loading Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #71 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132429&action=edit Bug 30055: Add missing include to format addresses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #73 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132431&action=edit Bug 30055: Add missing spec file for baskets Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #75 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132433&action=edit Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #77 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132435&action=edit Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132437&action=edit Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #81 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132439&action=edit Bug 30055: clear the column filter if none selected ie. search for "", not "^$" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #83 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132441&action=edit Bug 30055: API unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |severine.queune@bulac.fr --- Comment #85 from Séverine Queune <severine.queune@bulac.fr> --- About guarantor page (I'm not used to this functionality so I hope I use it correctly and tested it as expected) : 1) I love the big popup ! 2) I was surprised by the content of the table, as I expected something unified with the table in '-members-home.pl page, but it's not 3) Address is much bigger than the other informations, font-size should probably be set at 100% instead of 110% 4) Resetting a dropdown menu fails on new search. To reproduce : select a library or category in the dropdown and search ; reset the menu to 'Any' and search : results stay the same. Use 'Clear' option and launch a new search using 'Any' : results stay the same as initial search. About Suggestion's manager + Patron's card + Serial routing list + Users to notify when order is received + Owner and users of a fund pages : 5) I regret the pop-up isn't a big one as for guarantor (see point 1) : you have to scroll to see results which is not really a user-friendly thing. I opened a new bug for that. 6) same as point 4) 7) I also have the same search 'issues' described on bug 30063 for special signs (point 3) and search not correctly applied (point 4) About Manager of an acquisition basket : 8) I can't get any results whatever the permissions I set for different users (order_manage, order_manage_all, superlibrarian) Note that I tested as a superlibrairian user but didn't try with simple user permissions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132451&action=edit Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #89 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132453&action=edit Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #91 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132455&action=edit Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #93 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132457&action=edit Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #95 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132459&action=edit Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #97 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132461&action=edit Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #99 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132463&action=edit Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #101 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132465&action=edit Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #103 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132467&action=edit Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #105 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132469&action=edit Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #107 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132471&action=edit Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #109 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 132473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132473&action=edit Bug 30055: (follow-up) Adapt spec for bug 30194 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132539&action=edit Bug 30055: Add missing x-koha-embed for /acquisitions/baskets/managers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #112 from Séverine Queune <severine.queune@bulac.fr> --- All the points supposed be fixed by the present bug seems ok for me. But shame on me, I forgot one point in my previous feedback :/ Search 'Starts with' is down. To reproduce : select 'Standard' and 'Starts with' and search for 'ko' or 'koh' : there is supposed be 3 or 4 results but none are displayed. It seems this option searches for 'Is exactly' and not 'Starts with' it works when you search for 'koha'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132451|0 |1 is obsolete| | --- Comment #114 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132617&action=edit Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132453|0 |1 is obsolete| | --- Comment #116 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132619&action=edit Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132455|0 |1 is obsolete| | --- Comment #118 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132621&action=edit Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132457|0 |1 is obsolete| | --- Comment #120 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132623&action=edit Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132459|0 |1 is obsolete| | --- Comment #122 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132625&action=edit Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132461|0 |1 is obsolete| | --- Comment #124 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132628&action=edit Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132463|0 |1 is obsolete| | --- Comment #126 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132630&action=edit Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132465|0 |1 is obsolete| | --- Comment #128 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132632&action=edit Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132467|0 |1 is obsolete| | --- Comment #130 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132634&action=edit Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132469|0 |1 is obsolete| | --- Comment #132 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132636&action=edit Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132471|0 |1 is obsolete| | --- Comment #134 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132638&action=edit Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132473|0 |1 is obsolete| | --- Comment #136 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132640&action=edit Bug 30055: (follow-up) Adapt spec for bug 30194 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #138 from Séverine Queune <severine.queune@bulac.fr> --- All the bugs linked to this specific ticket are fixed, thanks Jonathan ! -- You are receiving this mail because: You are watching all bug changes.