[Bug 25563] New: Cannot sub "add order from MARC file" form after alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Bug ID: 25563 Summary: Cannot sub "add order from MARC file" form after alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 24386 If you get an alert about "no fund selected" you won't be able to submit the form. To recreate (test plan from bug 25473) - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Choose a fund - Save (at least try) - Nothing happens :< Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386 [Bug 24386] Double submit should be prevented when adding to a basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 01551437c0c99b9e6308e109ceeef5bc3f7b5cec Bug 24386: Prevent double form submission on adding orders to basket from a file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105171&action=edit Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function. The problem is that we are checking some conditions, and prevent the form submission if something is not filled (for instance no checkbox checked, or no fund selected). Technically it means that: - click the submit button - it submits the form - we disable the submit button - we prevent the form to be submitted before something is wrong At this stage the button is disabled and the form cannot be longer be submitted. This patch replaces the "on submit" event of the form with the "on click" event of the submit button. Which means we are going to: - click the submit button - we prevent the form to be submitted before something is wrong => The button will only be disabled if the form is really submitted Test plan: - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Save - You should see an expected error message - Choose a fund - Click the "Save" button as many times as you can, to try double submit it. => The order is saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot sub "add order from |Cannot submit "add order |MARC file" form after alert |from MARC file" form after | |alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105172&action=edit Bug 25563: Only submit form after is it checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #105172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105171|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105173&action=edit Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function. The problem is that we are checking some conditions, and prevent the form submission if something is not filled (for instance no checkbox checked, or no fund selected). Technically it means that: - click the submit button - it submits the form - we disable the submit button - we prevent the form to be submitted before something is wrong At this stage the button is disabled and the form cannot be longer be submitted. This patch replaces the "on submit" event of the form with the "on click" event of the submit button. Which means we are going to: - click the submit button - we prevent the form to be submitted before something is wrong => The button will only be disabled if the form is really submitted Test plan: - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Save - You should see an expected error message - Choose a fund - Click the "Save" button as many times as you can, to try double submit it. => The order is saved Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105173|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105183&action=edit Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function. The problem is that we are checking some conditions, and prevent the form submission if something is not filled (for instance no checkbox checked, or no fund selected). Technically it means that: - click the submit button - it submits the form - we disable the submit button - we prevent the form to be submitted before something is wrong At this stage the button is disabled and the form cannot be longer be submitted. This patch replaces the "on submit" event of the form with the "on click" event of the submit button. Which means we are going to: - click the submit button - we prevent the form to be submitted before something is wrong => The button will only be disabled if the form is really submitted Test plan: - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Save - You should see an expected error message - Choose a fund - Click the "Save" button as many times as you can, to try double submit it. => The order is saved Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org