[Bug 5526] New: List of lists should be in alphabetical order by list name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 Summary: List of lists should be in alphabetical order by list name Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Virtual Shelves AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 The list of patron's lists comes from VirtualShelves.pm's GetShelves, which includes this in the SQL: ORDER BY virtualshelves.category DESC I think it makes more sense to order by virtualshelves.shelfname. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-12-20 15:11:50 UTC --- Created attachment 2891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2891 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-29 07:42:47 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2010-12-29 12:24:44 UTC --- Created attachment 2915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2915 opac pull down this fix did not take into account the list of lists pull down in the opac -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2010-12-29 12:25:05 UTC --- Created attachment 2916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2916 staff pull down this fix did not take into account the list of lists pull down in the staff client -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2010-12-29 13:46:53 UTC ---
this fix did not take into account the list of lists pull down in the opac this fix did not take into account the list of lists pull down in the staff client
No, and it did not attempt to. The lists in the screenshots you attached are generated by a function that pulls the 10 most recent lists ordered by `lastmodified`, and the changes I made in this patch were made specifically to this page: /cgi-bin/koha/opac-shelves.pl?display=privateshelves The GetRecentShelves subroutine could easily be made to order by list name, but I think it's contrary to the original intention of those displays. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5526 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2010-12-29 19:46:17 UTC --- Okey Dokey, then this works as expected :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org