https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 Bug ID: 41837 Summary: Are we ready for rc1? Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Ready? commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f Date: Tue Dec 2 22:13:25 2003 +0000 fix for bug 600 modified: C4/Output.pm -my $path = C4::Context->config('includes') || - "/usr/local/www/hdl/htdocs/includes"; +#FIXME: this is a quick fix to stop rc1 installing broken +#Still trying to figure out the correct fix. +my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/"; This FIXME got moved to C4/Templates.pm: commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9 Date: Thu Aug 25 15:01:19 2011 +0200 Bug 6755 Problems with switching languages I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193011&action=edit Bug 41837: Remove $path from C4::Templates commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f Date: Tue Dec 2 22:13:25 2003 +0000 fix for bug 600 modified: C4/Output.pm -my $path = C4::Context->config('includes') || - "/usr/local/www/hdl/htdocs/includes"; +#FIXME: this is a quick fix to stop rc1 installing broken +#Still trying to figure out the correct fix. +my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/"; This FIXME got moved to C4/Templates.pm: commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9 Date: Thu Aug 25 15:01:19 2011 +0200 Bug 6755 Problems with switching languages I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41834 [Bug 41834] Remove systempreferences's options, explanation and type DB values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Test plan: confirm that this "$path" variable is never used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #3 from David Nind <david@davidnind.com> --- Not sure how to test this, so will leave up to a developer/someone who understands the code, and what this does. (What is "rc1"?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #3)
Not sure how to test this, so will leave up to a developer/someone who understands the code, and what this does. (What is "rc1"?)
I think a reasonable test would just be to apply the patch and check that pages still load correctly. rc1 is release candidate 1 and this bit of code actually originates from pre-2007 (I stopped tracking it once I hit 2007), and it looks like it didn't even work properly back then haha. If you're not keen to sign off, I might just push it straight to Passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #4)
I think a reasonable test would just be to apply the patch and check that pages still load correctly.
Which page? (Or is this any staff interface page?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #5)
(In reply to David Cook from comment #4)
I think a reasonable test would just be to apply the patch and check that pages still load correctly.
Which page? (Or is this any staff interface page?)
Yeah, any staff interface or OPAC page. It doesn't really matter so long as it's rendering a template. I'm happy to look at it later as well and push straight to QA once I've tested. I think I just need to grab a bit of lunch first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193011|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 194420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194420&action=edit Bug 41837: Remove $path from C4::Templates commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f Date: Tue Dec 2 22:13:25 2003 +0000 fix for bug 600 modified: C4/Output.pm -my $path = C4::Context->config('includes') || - "/usr/local/www/hdl/htdocs/includes"; +#FIXME: this is a quick fix to stop rc1 installing broken +#Still trying to figure out the correct fix. +my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/"; This FIXME got moved to C4/Templates.pm: commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9 Date: Thu Aug 25 15:01:19 2011 +0200 Bug 6755 Problems with switching languages I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes unused code (a release notes| |hard-coded path in | |templates) that is no | |longer used in Koha (it was | |added pre-2007 for a | |release candidate). --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Accessed some random pages in various modules (staff interface and OPAC), including adding and editing information (such as patrons, records, authorities), as well as placing holds, checking things out and back in, and so on. 2. Had browser tools console open as well. 3. Pages seemed to load correctly without any errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194420|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 194615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194615&action=edit Bug 41837: Remove $path from C4::Templates commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f Date: Tue Dec 2 22:13:25 2003 +0000 fix for bug 600 modified: C4/Output.pm -my $path = C4::Context->config('includes') || - "/usr/local/www/hdl/htdocs/includes"; +#FIXME: this is a quick fix to stop rc1 installing broken +#Still trying to figure out the correct fix. +my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/"; This FIXME got moved to C4/Templates.pm: commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9 Date: Thu Aug 25 15:01:19 2011 +0200 Bug 6755 Problems with switching languages I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- David and David (D&D) getting things done :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Removes unused code, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org