[Bug 27430] New: Use minimum length for patron category on password hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Bug ID: 27430 Summary: Use minimum length for patron category on password hint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |emmi.takkinen@koha-suomi.fi --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 115154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115154&action=edit Bug 27430 - Use password minimum length for patron category on password hint Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" 5. Apply patch. 6. Hint should now read "Minimum password length: 4". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115154|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115157&action=edit Bug 27430: Use password minimum length for patron category on password hint Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" 5. Apply patch. 6. Hint should now read "Minimum password length: 4". Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I would suggest we make this change in member-password.tt too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #3)
I would suggest we make this change in member-password.tt too.
I've tried to see where this is needed it it looked ok to me - can you explaina bit more? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115157|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115226&action=edit Bug 27430: Use password minimum length for patron category on password hint Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" 5. Apply patch. 6. Hint should now read "Minimum password length: 4". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This corrects the hint on release notes| |the patron add/edit form to | |take into account that the | |minimum password length can | |now also be set on patron | |category level. Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- While this improves the situation, there is still an issue: When the patron category is changed, the hint might be wrong. Do we need an ajax call here to adjust the hint to the patron category selected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Owen Leonard from comment #3)
I would suggest we make this change in member-password.tt too.
I don't see where in member-password.tt this would be necessary. Did you mean some other page? (In reply to Katrin Fischer from comment #6)
While this improves the situation, there is still an issue: When the patron category is changed, the hint might be wrong. Do we need an ajax call here to adjust the hint to the patron category selected?
Good point. This might be confusing for users especially when error message is adjusted by the selected patron category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 115233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115233&action=edit Bug 27430: Change password minimum value hint when patron category is changed If patrons category is changed during add or edit password minimum value doesn't change. This patch adds ajax call to fix this. To test: 1. Add password minimum length for patron categories A and B. 2. Create a new patron with category A. 3. Change patrons category to B. 4. Note that password minimum value doesn't change on hint text. 5. Apply patch. 6. Repeat patron creation, password minimum value should now change correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115226|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115316&action=edit Bug 27430: Use password minimum length for patron category on password hint Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" 5. Apply patch. 6. Hint should now read "Minimum password length: 4". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115233|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115317&action=edit Bug 27430: Change password minimum value hint when patron category is changed If patrons category is changed during add or edit password minimum value doesn't change. This patch adds ajax call to fix this. To test: 1. Add password minimum length for patron categories A and B. 2. Create a new patron with category A. 3. Change patrons category to B. 4. Note that password minimum value doesn't change on hint text. 5. Apply patch. 6. Repeat patron creation, password minimum value should now change correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #11 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Emmi Takkinen from comment #7)
(In reply to Owen Leonard from comment #3)
I would suggest we make this change in member-password.tt too.
I don't see where in member-password.tt this would be necessary. Did you mean some other page?
Wouldn't we want to show the required password length on the page for changing the patron's username and password? /cgi-bin/koha/members/member-password.pl?member=XXX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #12)
(In reply to Emmi Takkinen from comment #7)
(In reply to Owen Leonard from comment #3)
I would suggest we make this change in member-password.tt too.
I don't see where in member-password.tt this would be necessary. Did you mean some other page?
Wouldn't we want to show the required password length on the page for changing the patron's username and password?
/cgi-bin/koha/members/member-password.pl?member=XXX
Hm it did show for me in testing, but only after I had tried to save a too short one - mean to show the hint always? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115317|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116105&action=edit Bug 27430: Change password minimum value hint when patron category is changed If patrons category is changed during add or edit password minimum value doesn't change. This patch adds ajax call to fix this. To test: 1. Add password minimum length for patron categories A and B. 2. Create a new patron with category A. 3. Change patrons category to B. 4. Note that password minimum value doesn't change on hint text. 5. Apply patch. 6. Repeat patron creation, password minimum value should now change correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Emmi for fixing the "category change"! I believe this is a nice bug fix fixing the wrong information shown on the edit patron screen. I verified that the hint you get on using the "change password" feature is already correct. Showing a hint there always and not only when entering a wrong length one might be nice, but I think we can treat it as a separate enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115316|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116106&action=edit Bug 27430: Use password minimum length for patron category on password hint Hint for password minimum length should use minimum length set for patron category not "minPasswordLength" value. To test: 1. Set "minPasswordLength" e.g. 6 2. Set "Patron" category minimum password length e.g. 4 3. Create new a patron. 4. Note that hint after password input field reads "Minimum password length: 6" 5. Apply patch. 6. Hint should now read "Minimum password length: 4". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116105|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116107&action=edit Bug 27430: Change password minimum value hint when patron category is changed If patrons category is changed during add or edit password minimum value doesn't change. This patch adds ajax call to fix this. To test: 1. Add password minimum length for patron categories A and B. 2. Create a new patron with category A. 3. Change patrons category to B. 4. Note that password minimum value doesn't change on hint text. 5. Apply patch. 6. Repeat patron creation, password minimum value should now change correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- In my understanding we never see <div class="hint">Minimum password length: [% patron.category.effective_min_password_length | html %]</div> as it's replaced by the JS code. Shouldn't we remove it then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1573 [% IF categorycode %] 1574 update_category_code( "[% categorycode | html %]" ); 1575 [% ELSE %] 1576 if ( $("#categorycode_entry").length > 0 ){ 1577 var category_code = $("#categorycode_entry").find("option:selected").val(); 1578 update_category_code( category_code ); 1579 } 1580 [% END %] update_category_code COULD not be called on document.ready. But I am not sure we display the form without the category dropdown list. I will push as it, don't want to mess with this form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23816 CC| |andrew@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 [Bug 23816] Allow to have different password strength and length settings for different patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org