[Bug 26236] New: log viewer does not translate the interface properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Bug ID: 26236 Summary: log viewer does not translate the interface properly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org viewlog.tt 83 [% BLOCK translate_log_interface %] 84 [% SWITCH log_interface %] 85 [% CASE 'INTRANET' %]Intranet 86 [% CASE 'OPAC' %]OPAC 87 [% CASE 'SIP' %]SIP 88 [% CASE 'COMMANDLINE' %]Command-line 89 [% CASE 'API' %]REST API 90 [% CASE 'CRON' %]Cron job 91 [% CASE %][% log_interface | html %] 92 [% END %] 93 [% END %] We don't have CRON in DB, but 'cron', same for all others, they are all lowercase. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 108506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108506&action=edit Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108506|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109586&action=edit Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly https://bugs.koha-community.org/show_bug.cgi?id=26236 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Good catch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109586|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109595&action=edit Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109596&action=edit Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #109595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, simple fix. I corrected the bug number in the commit message to match the bug here. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org