[Bug 11843] New: Manual subscription history doesn't seem to work as expected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Bug ID: 11843 Summary: Manual subscription history doesn't seem to work as expected Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com I noticed some things when testing another patch: - When the manual history check box is set in the subscription, the summary tab is no longer updated manually. - When you deactivate the manual history, the summary is partially recreated when you receive the next issue or mark the next issue missing. Your additions are lost. But the manual history edit page states: Hint : you can update the serial history manually. This can be useful for an old subscription or to clean the existing history. Modify those fields with care, as future serial recieve will continue to update them automatically. I think it used to be, that the history was only amended for new issues, not recreated. So it kept your notes. Setting priority a bit higher on this one, as this can cause unwanted loss of information on your serials history. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked the manual, trying to find more about how this should be working, but we only have a short note there: Checking the 'Manual history' box will allow you to enter serials outside the prediction pattern. http://manual.koha-community.org/3.14/en/newsubscription.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Severity|major |blocker --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thinking more about this, I think it's a blocker for the possibility of losing data by an unexpected change of behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice@biblibre.com Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27713&action=edit Bug 11843: Reset the old code for updating manual subscription history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- I reset the old code so this should work exactly like before bug 7688 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27713|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27714&action=edit Bug 11843: Reset the old code for updating manual subscription history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- added test plan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- The patch causes a test failure in t/db_dependent/Serials.t: not ok 44 - subscription missinglist is updated after ModSerialStatus # Failed test 'subscription missinglist is updated after ModSerialStatus' # at t/db_dependent/Serials.t line 242. # got: 'No.7; No.8; No.9; No.10; No.11; No.12; not issued No.13' # expected: 'not issued No.13; No.12; No.11; No.10; No.9; No.8; No.7' # Looks like you failed 1 test of 44. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28006&action=edit Bug 11843: Fix unit test in t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27714|0 |1 is obsolete| | Attachment #28006|0 |1 is obsolete| | --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28039&action=edit Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28039|0 |1 is obsolete| | --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28040&action=edit Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28041&action=edit Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #12 from Paola Rossi <paola.rossi@cineca.it> --- I also test the patch [against master 3.15.00.051]. I agree about signing off the patch. NB 1) At 3/, on receiving issues [by subscription-detail.pl], I see "Save" and "Multi receiving" buttons, but the first one only is selectable. On the contrary, using serials-collection.pl, f.i. at "manage" tab, I see three buttons: "Edit serials", "Generate next" and "Multi receiving", and all the three buttons are selectable. ------------------------------------- NB 2) At 3/, my expectation about the "Issues" tab of a subscription [on subscription-detail.pl] is the complete list of its issues. At 3/, on receiving I set the n-th issue at "Late" status. Then I receive the (n+1)-th issue, and I set it at "Missing" status. Soon after I multi-receive 2 issues. Then I look at the "Issues" tab of the subscription [on subscription-detail.pl]: the 2 "Arrived" issues I've just multi-received are not listed here! Neither the "Missing" (n+1)-th issue is listed here! [On the contrary, in the "Issues" tab the "Expected" (n+4)-th issue is correctly listed, and the "Late" n-th is correctly listed too.] ------------------------------------- NB 3) At 6/, I change the issue's status, as the test plan requires. The "Not available" status [on serials-edit.pl] is named "Not issued" in "manage" tab [on serials-collection.pl] and in "Missing issues:" of Summary [on subscription-detail.pl]. ------------------------------------- NB 4) At 6/: From "Edit serial" tab, on changing the issue status [on serials-edit.pl], the user is allowed to change the "Numbered" field of the issue too. If the user changes this field, the text already added in the "Summary" for that issue [at the two "Receiving issues:" and "Missing issues:" paragraphs] is aligned no more to a further updated status of that issue. -------------------------------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28040|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28127&action=edit [PASSED QA] Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history Test plan: 1/ Create a new subscription, with manual history enabled 2/ Edit history by clicking on "Edit history" under Planning tab (add some text) 3/ Receive some serials, see that received and missing issues are not updated in Summary tab 4/ Edit subscription and disable manual history 5/ Receive some serials, see that received and missing issues are updated, but your notes have been kept. 6/ Edit serials and change status from/to missing or not available. Check that missing issues are updated correctly. 7/ Edit serials and change status from/to arrived. Check that received issues are updated correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28041|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28128&action=edit [PASSED QA] Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12369 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org