http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 09:27:16 UTC --- Created attachment 4789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4789 Bug 6553 : Follow up adding license statements -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 09:56:41 UTC --- The content of attachment 4789 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2011-08-01 21:56:37 NZST. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-29 01:59:54 UTC --- Actually brackets in authors is broken in both xslt and normal display, works in facets -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |ian.walls@bywatersolutions. | |com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5680|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 18:44:10 UTC --- Created attachment 5991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5991 [SIGNED-OFF] Bug 6553: parentheses in authors break tracings If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC and staff client fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: - Create a new framework, delete Thesaurus from 700 and other fields - Create a new record in this framework - Add 700$a - use parentheses - Check the search links in OPAC and staff detail pages

before patch link was broken, after it works

Note: Links are only broken when no authorities are being used. When using authorities the link uses the auth number instead of the text for linking, so the parentheses don't matter for search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 18:54:21 UTC --- XSLT-only change adding "" around authors to prevent tracings from breaking. As I would normally mark this as Passed QA, so shall I now, unless anyone objects. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|CLOSED |REOPENED CC| |kyle@bywatersolutions.com Resolution|FIXED |--- --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- I believe this problem has come back. All the relevant fixed code is gone from master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5991|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5991|0 |1 is obsolete| | --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 18055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18055&action=edit Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18055|0 |1 is obsolete| | --- Comment #16 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18445&action=edit Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18445|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19303&action=edit [PASSED QA] Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change adding quotes. Search now matches search in the intranet. Passes all tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes.