[Bug 18748] New: Noisy t/db_dependent/AuthorisedValues.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Bug ID: 18748 Summary: Noisy t/db_dependent/AuthorisedValues.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com prove t/db_dependent/AuthorisedValues.t DBD::mysql::st execute failed: Duplicate entry 'ACQ-952-c' for key 'PRIMARY' [for Statement "INSERT INTO `marc_subfield_structure` ( `authorised_value`, `frameworkcode`, `kohafield`, `tagfield`, `tagsubfield`) VALUES ( ?, ?, ?, ?, ? )" with ParamValues: 0='LOC', 1='ACQ', 2='items.location', 3=952, 4='c'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry 'ACQ-952-c' for key 'PRIMARY' at /home/mtompset/kohaclone/Koha/Object.pm line 121 # Child (search_by_*_field + find_by_koha_field + get_description) exited without calling finalize() not ok 15 - search_by_*_field + find_by_koha_field + get_description Seems that bug 17249 adds both a 952$c for the '' and 'ACQ' framework, but the deletes above only delete the '' framework one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17249 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64084&action=edit Bug 18748: Noisy t/db_dependent/AuthorisedValues.t This noise is from a failure. This patch expands the delete regardless of framework. TEST PLAN --------- prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- I ran 'prove t/db_dependent/AuthorisedValues.t' however I did not encounter any noise. For me, the test was successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Lee Jamison from comment #2)
I ran 'prove t/db_dependent/AuthorisedValues.t' however I did not encounter any noise. For me, the test was successful.
Purposefully add a 952$c 'ACQ' framework into your DB. I likely got this as a result of killing the test before it completed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64084|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64112&action=edit Bug 18748: Noisy t/db_dependent/AuthorisedValues.t This noise is from a failure. This patch expands the delete regardless of framework. TEST PLAN --------- prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Test is green after running as directed by the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mark, could you make the change more explicit? It would make more sense to delete 952c for the default and ACQ frameworks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Attachment #64112|0 |1 is obsolete| | Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64312&action=edit Bug 18748: Noisy t/db_dependent/AuthorisedValues.t This noise is from a failure. This patch expands the delete to 952$c for the ACQ framework as per comment #5. TEST PLAN --------- insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999); -- this makes sure you have a pre-existing 952$c ACQ record. prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64312|0 |1 is obsolete| | --- Comment #7 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64433&action=edit Bug 18748: Noisy t/db_dependent/AuthorisedValues.t This noise is from a failure. This patch expands the delete to 952$c for the ACQ framework as per comment #5. TEST PLAN --------- insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999); -- this makes sure you have a pre-existing 952$c ACQ record. prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works as described following the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64433|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65047&action=edit Bug 18748: Noisy t/db_dependent/AuthorisedValues.t This noise is from a failure. This patch expands the delete to 952$c for the ACQ framework as per comment #5. TEST PLAN --------- insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999); -- this makes sure you have a pre-existing 952$c ACQ record. prove t/db_dependent/AuthorisedValues.t -- should have ugly message like in comment #0 apply patch prove t/db_dependent/AuthorisedValues.t -- should be green run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org