[Bug 38679] New: GET /deleted/biblios missing some mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Bug ID: 38679 Summary: GET /deleted/biblios missing some mappings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com When we implemented the `GET /deleted/biblios` endpoint, we missing the mapping for the `biblioitems` table attributes. To reproduce: 1. Pick a sample record ID 2. Fetch is using the API with your favourite tool: GET /api/v1/biblios/<the ID> Accept: application/json 3. Save the output for later 4. Delete the record 5. Fetch the deleted biblio using the API: GET /api/v1/deleted/biblios/<the ID> Accept: application/json 6. Compare the results => FAIL: Attributes like `volumedate` are not mapped! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED Depends on| |33960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 [Bug 33960] Add ability to retrieve deleted bibliographic records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175378&action=edit Bug 38679: Add attribute mappings Koha::Old::Biblioitem This trivial patch replicates the mappings in Koha::Biblioitem. To test: 1. Pick a sample record ID 2. Fetch is using the API with your favourite tool: GET /api/v1/biblios/<the ID> Accept: application/json 3. Save the output for later 4. Delete the record 5. Fetch the deleted biblio using the API: GET /api/v1/deleted/biblios/<the ID> Accept: application/json 6. Compare the results => FAIL: Attributes like `volumedate` are not mapped! 7. Apply this patch 8. Repeat 5 => SUCCESS: Attributes are mapped! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175378|0 |1 is obsolete| | --- Comment #2 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Created attachment 176302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176302&action=edit Bug 38679: Add attribute mappings Koha::Old::Biblioitem This trivial patch replicates the mappings in Koha::Biblioitem. To test: 1. Pick a sample record ID 2. Fetch is using the API with your favourite tool: GET /api/v1/biblios/<the ID> Accept: application/json 3. Save the output for later 4. Delete the record 5. Fetch the deleted biblio using the API: GET /api/v1/deleted/biblios/<the ID> Accept: application/json 6. Compare the results => FAIL: Attributes like `volumedate` are not mapped! 7. Apply this patch 8. Repeat 5 => SUCCESS: Attributes are mapped! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Check field names again in public_read_list: 'columedesc' ? 'cn)item' ?? Looks like you had to run for the bus? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #3)
Check field names again in public_read_list: 'columedesc' ? 'cn)item' ??
Looks like you had to run for the bus? :)
LOL. I just copied and pasted from Koha/Biblioitem.pm Will submit a fixed version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176302|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176881&action=edit Bug 38679: Add attribute mappings Koha::Old::Biblioitem This trivial patch replicates the mappings in Koha::Biblioitem. To test: 1. Pick a sample record ID 2. Fetch is using the API with your favourite tool: GET /api/v1/biblios/<the ID> Accept: application/json 3. Save the output for later 4. Delete the record 5. Fetch the deleted biblio using the API: GET /api/v1/deleted/biblios/<the ID> Accept: application/json 6. Compare the results => FAIL: Attributes like `volumedate` are not mapped! 7. Apply this patch 8. Repeat 5 => SUCCESS: Attributes are mapped! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176882&action=edit Bug 38679: (follow-up) Fix old typos in column names Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176881|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176948&action=edit Bug 38679: Add attribute mappings Koha::Old::Biblioitem This trivial patch replicates the mappings in Koha::Biblioitem. To test: 1. Pick a sample record ID 2. Fetch is using the API with your favourite tool: GET /api/v1/biblios/<the ID> Accept: application/json 3. Save the output for later 4. Delete the record 5. Fetch the deleted biblio using the API: GET /api/v1/deleted/biblios/<the ID> Accept: application/json 6. Compare the results => FAIL: Attributes like `volumedate` are not mapped! 7. Apply this patch 8. Repeat 5 => SUCCESS: Attributes are mapped! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176882|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176949&action=edit Bug 38679: (follow-up) Fix old typos in column names Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org