[Bug 31756] New: Biblionumber not numerically sorting natively when using Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Bug ID: 31756 Summary: Biblionumber not numerically sorting natively when using Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au When bug 30879 was pushed, we didn't know how to natively sort numbers, but we do now. This issue seeks to replace the workaround with the native implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 141759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141759&action=edit Bug 31756: Use native Zebra numeric sort for biblionumber This patch uses native Zebra numeric sort for biblionumber to provide ascending and descending biblionumber sort in Koha. To test: 1. Apply patches 2. koha-plack --restart kohadev 3. Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl? idx=kw&q=a&sort_by=biblionumber_dsc&count=20 4. Confirm records sorted correctly 5. Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl? idx=kw&q=a&sort_by=biblionumber_asc&count=20 6. Confirm records sorted correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 141760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141760&action=edit Bug 31756: Undo zeropad workaround for Local-Number:s for MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 141761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141761&action=edit Bug 31756: Undo zeropad workaround for Local-Number:s for UNIMARC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Actually, the test plan should be the same as bug 30879: To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly And same again for UNIMARC... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #5 from David Nind <david@davidnind.com> --- Hi David. Things seem to be working for MARC21. However, for UNIMARC: - I changed the count number =100 - After the first 10 pages of results (that is, from page 11 and the 1001 search result) the order changes to asc starting from 1 It works fine for asc. Note: when copying the definitions in step 2, I replaced marc21 with unimarc in the file paths. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #5)
Hi David.
Things seem to be working for MARC21.
However, for UNIMARC: - I changed the count number =100 - After the first 10 pages of results (that is, from page 11 and the 1001 search result) the order changes to asc starting from 1
It works fine for asc.
Note: when copying the definitions in step 2, I replaced marc21 with unimarc in the file paths.
David
Could you elaborate a bit more? You say the order changes to "asc". Does that mean it was "desc" before? I don't think that's an issue with these patches. Also, in ./etc/zebradb/zebra-biblios-dom.cfg, you'll probably notice that "sortmax" is set to "1000". That means that only the first 1000 records in a result set will be sorted, so that might be what you're encountering. That means only the first 1000 records are sorted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #6)
Could you elaborate a bit more? You say the order changes to "asc". Does that mean it was "desc" before?
Yes. For UNIMARC, when I used the URL with dsc in it: - Results 1 to 1,000 appear to sort correctly, with biblo records in descending order - For result 1,001 the biblio number of the record displayed is 1, and then it continues in ascending order for the rest of the paged set of results (until "last") If there is a setting that limits the sorting to 1,000, then I would expect this to happen with the URL with asc in it as well, but it doesn't - everything appears to be as expected with all the results set 4,000+ sorting correctly. Maybe for the asc URL this is the "default" for the Zebra config, would that explain why they act differently? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #7)
(In reply to David Cook from comment #6)
Could you elaborate a bit more? You say the order changes to "asc". Does that mean it was "desc" before?
Yes.
For UNIMARC, when I used the URL with dsc in it: - Results 1 to 1,000 appear to sort correctly, with biblo records in descending order - For result 1,001 the biblio number of the record displayed is 1, and then it continues in ascending order for the rest of the paged set of results (until "last")
If there is a setting that limits the sorting to 1,000, then I would expect this to happen with the URL with asc in it as well, but it doesn't - everything appears to be as expected with all the results set 4,000+ sorting correctly.
Maybe for the asc URL this is the "default" for the Zebra config, would that explain why they act differently?
Yeah, the default sort in Zebra is ascending by internal record number which is the same as biblionumber. What happens with MARC21? Surely it must be the same behaviour... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #8)
Yeah, the default sort in Zebra is ascending by internal record number which is the same as biblionumber.
What happens with MARC21? Surely it must be the same behaviour...
There are only 400 odd records in the sample data set, so doesn't show as an issue. I've had no luck exporting all the records from Koha and then importing at the moment, so can't test this out... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- I don't see any problems with 1000+ records in MARC21 I wonder though, do we need to remove the XSLT changes? The sorting works the same with or without them, and helps those who might not know enough about YAZ options but use Z39.50 to search Koha. I suggest dropping the last two patches. Sorting will still work without a reindex. Happy to add my stamp once David is good for sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #10)
I don't see any problems with 1000+ records in MARC21
I wonder though, do we need to remove the XSLT changes? The sorting works the same with or without them, and helps those who might not know enough about YAZ options but use Z39.50 to search Koha. I suggest dropping the last two patches.
I'm happy for the last two patches to be dropped. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #5)
However, for UNIMARC: - I changed the count number =100 - After the first 10 pages of results (that is, from page 11 and the 1001 search result) the order changes to asc starting from 1
Have you tried testing this before applying the patch? Does it only happy with these patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 [Bug 30879] Add option to sort components by biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What's the status here? Should the last 2 patches be obsoleted and this be retested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #13)
What's the status here? Should the last 2 patches be obsoleted and this be retested?
I suppose I'm fairly indifferent overall. I'm probably OK with this just being Failed QA / Resolved Won't Fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13976 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org