[Bug 23796] New: Convert OpacCustomSearch system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Bug ID: 23796 Summary: Convert OpacCustomSearch system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 22318 Building on 22318, the OpacCustomSearch system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 [Bug 24745] OPAC news block plugin should evaluate as false if there are no items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99711&action=edit Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Claudie Trégouët <claudie.tregouet@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claudie.tregouet@biblibre.c | |om Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Claudie Trégouët <claudie.tregouet@biblibre.com> --- I've tried to apply this patch but I've got an error. I paste what I've got here : Bug 23796 - Convert OpacCustomSearch system preference to news block 99711 - Bug 23796: Convert OpacCustomSearch system preference to news block Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23796: Convert OpacCustomSearch system preference to news block error: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 23796: Convert OpacCustomSearch system preference to news block The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23796-Convert-OpacCustomSearch-system-preferen-30tSIU.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99711|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103160&action=edit Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103160|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 103324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103324&action=edit Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103324|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106620&action=edit Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, what is the purpose of the "blocktitle" param in the TT plugin? Looks like it's not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm trying to add new content through the news tool, but I'm not able to... 1) Go to Tools > News 2) Add a new news item with display location set to OpacCustomSearch(en) (I put <h1>OpacCustomSearch</h1> in mine) 3) Go to OPAC and refresh (or restart plack or memcached or something) Here, I'm not seeing <h1>OpacCustomSearch</h1> anywhere Is anyone able to add new content? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nick filed bug 26810 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org