[Bug 5067] New: bulkmarcimport.pl import script removes dashes in ISBN fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Summary: bulkmarcimport.pl import script removes dashes in ISBN fields Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Command-line Utilities AssignedTo: gmcharlt@gmail.com ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Import script shouldn't remove an information present in entering biblio records. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Should it be a switchable option? There are good reasons for removing the (often erroneous) hyphens. And standard usage in marc is without the hyphens. (NB you can generate hyphens from a un-hyphenated number using the perl module Business::ISBN) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> ---
Should it be a switchable option? There are good reasons for removing the (often erroneous) hyphens. And standard usage in marc is without the hyphens.
Yes, but when you have hand crafted a biblio record file with ISBN containing hyphens you prefer not to loose them. That's interesting: MARC21 records seems to have no hyphens, you're correct, but UNIMARC records have generally hyphens in ISBN field (BNF and SUDOC) and there is EAN field for ISBN without -... We can conclude that for MARC21 entering bibli records we don't have to remove hyphens since they shouldn't have any. And for UNIMARC records, we mustn't remove them since they are expected by the standard.
(NB you can generate hyphens from a un-hyphenated number using the perl module Business::ISBN)
I already appreciate and use this very useful module. Thanks Colin for the tip. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5012 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-14 02:31:26 UTC --- What's the current state of this patch? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2010-12-14 06:29:31 UTC ---
What's the current state of this patch?
Here it is: http://lists.koha-community.org/pipermail/koha-patches/2010-December/013262.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Stefano Bargioni <bargioni@pusc.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni@pusc.it --- Comment #5 from Stefano Bargioni <bargioni@pusc.it> 2011-04-12 10:17:22 UTC --- In my opinion, removing dashes from ISBN must be an option. Anyway, ISBN is a repeatable field. Currently, bulkmarcimport.pl removes dashes only from the first occurrence. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> 2011-04-12 11:04:47 UTC --- Created attachment 3892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3892 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-04-12 11:07:05 UTC ---
In my opinion, removing dashes from ISBN must be an option.
This is the case in my proposed patch. You just have to sign it.
Anyway, ISBN is a repeatable field. Currently, bulkmarcimport.pl removes dashes only from the first occurrence.
And still the case in my patch. But it isn't a big deal to fix it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-12 23:43:37 UTC --- This was submitted well before the feature freeze, (December in fact) so I have pushed it, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5067 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org