[Bug 18306] New: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Bug ID: 18306 Summary: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alexandre.breton@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 61338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61338&action=edit renew buttons circled in red Hi, Some of our staff users reports that when students are doing a search in the OPAC, the buttons "Renew selected" and "Renew all" are confusing for them (circled in red). They think they are able to renew their books but in fact they aren't allowed to do this. The problem is when the "OpacRenewalAllowed" is disabled, these buttons stay there and/or keep the same appearance. Thanks for helping, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Hi Alexandre, I can not reproduce on current master. What Koha version is it? Marc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #2 from Alexandre <alexandre.breton@ccsr.qc.ca> --- Hi Marc, We use v3.22, we will soon pass to 16.05 however. Thanks for helping, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.22 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #3 from Alexandre <alexandre.breton@ccsr.qc.ca> --- Very sorry for this second post. After a discussion with my collegue Marjorie, it's appears that this bug is in 16.11 too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Alexandre <alexandre.breton@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |16.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #4 from Alexandre <alexandre.breton@ccsr.qc.ca> --- I just tested it in 16.11 too, they still there. We can also observe an error message (in yellow) when we try the "renew all" button (see second picture): " Your loan renewal failed because of the following reason(s): You have renewed this item the maximum number of times allowed. You have renewed this item the maximum number of times allowed." I must admit that can be very confusing for a student. These buttons let the student think that they can renew their books by themself and at home (OPAC) but they will realise just in the last days of their loans that they can't... This message don't help them to understand the situation. Marc, which version did you use ? Maybe it was corrected for 17.05 but I didn't see any bug on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #5 from Alexandre <alexandre.breton@ccsr.qc.ca> --- Created attachment 61400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61400&action=edit error message with renew button in 16.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #6 from Marc Véron <veron@veron.ch> --- (In reply to Alexandre from comment #4) (...)
Marc, which version did you use ? Maybe it was corrected for 17.05 but I didn't see any bug on this. Current master (16.12.00.013)
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |OPAC Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I don't know if it's the only condition which creates the problem, but I see that having OverduesBlockRenewing set to 'block' or 'blockitem' can lead to a situation where the renew links are displayed but no checkboxes appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca, | |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #8 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Still valid in 18.05 Marjorie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86853&action=edit Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it This patch add additional checks to opac-user.pl defining the ability to renew some or all items. The template can now better check whether it should show the renewal controls. To test, apply the patch and log in to the OPAC as a user with multiple checkouts. Test the following conditions: - All checkouts can be renewed - "Renew selected" and "Renew all" should appear at the top and bottom of the table of checkouts. - No checkouts can be renewed - No renewal controls should appear. - Some checkouts can be renewed - "Renew selected" should appear but not "Renew all" Test with various settings of the OverduesBlockRenewing system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #10 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Owen Leonard from comment #9)
Created attachment 86853 [details] [review] Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it
This patch add additional checks to opac-user.pl defining the ability to renew some or all items. The template can now better check whether it should show the renewal controls.
To test, apply the patch and log in to the OPAC as a user with multiple checkouts. Test the following conditions:
- All checkouts can be renewed - "Renew selected" and "Renew all" should appear at the top and bottom of the table of checkouts. - No checkouts can be renewed - No renewal controls should appear. - Some checkouts can be renewed - "Renew selected" should appear but not "Renew all"
Test with various settings of the OverduesBlockRenewing system preference.
Hi Owen, I tested it on sandbox http://catalogue.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/opac-user.pl and link Renew selected still appears even if all my checkout are not renewable. OverduesBlockRenewing is set on allow renewing Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #11 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Created attachment 86855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86855&action=edit not renewable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marjorie Barry-Vila from comment #10)
even if all my checkout are not renewable.
Why are your checkouts not renewable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #13 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Owen Leonard from comment #12)
(In reply to Marjorie Barry-Vila from comment #10)
even if all my checkout are not renewable.
Why are your checkouts not renewable?
I used all the renewals available according to the circulation rules. Marjorie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- I see this too, renew selected appears even if there are no items available to renew. It seems to work correctly when OverduesBlockRenewing is set to block. Sorry Owen. :( -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org